FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Redhat > Crash Utility

 
 
LinkBack Thread Tools
 
Old 02-12-2009, 03:22 AM
Jun Koi
 
Default remove abundant code in memory.c

Hi,

This patch removes abundant code in memory.c

Thanks,
Jun


diff a/memory.c b/memory.c
--- a/memory.c
+++ b/memory.c
@@ -3369,7 +3369,6 @@ clear_vma_cache(void)
void
get_task_mem_usage(ulong task, struct task_mem_usage *tm)
{
- int rdflags;
struct task_context *tc;

BZERO(tm, sizeof(struct task_mem_usage));
@@ -3377,8 +3376,6 @@ get_task_mem_usage(ulong task, struct task_mem_usage *tm)
if (IS_ZOMBIE(task) || IS_EXITING(task))
return;

- rdflags = ACTIVE() ? (QUIET|RETURN_ON_ERROR) : RETURN_ON_ERROR;
-
tc = task_to_context(task);

if (!tc || !tc->mm_struct) /* probably a kernel thread */

--
Crash-utility mailing list
Crash-utility@redhat.com
https://www.redhat.com/mailman/listinfo/crash-utility
 
Old 02-12-2009, 12:38 PM
Dave Anderson
 
Default remove abundant code in memory.c

----- "Jun Koi" <junkoi2004@gmail.com> wrote:

> Hi,
>
> This patch removes abundant code in memory.c
>
> Thanks,
> Jun

Yeah, looks like there was a readmem() call removed.
Queued for the next release.

Thanks,
Dave

>
>
> diff a/memory.c b/memory.c
> --- a/memory.c
> +++ b/memory.c
> @@ -3369,7 +3369,6 @@ clear_vma_cache(void)
> void
> get_task_mem_usage(ulong task, struct task_mem_usage *tm)
> {
> - int rdflags;
> struct task_context *tc;
>
> BZERO(tm, sizeof(struct task_mem_usage));
> @@ -3377,8 +3376,6 @@ get_task_mem_usage(ulong task, struct
> task_mem_usage *tm)
> if (IS_ZOMBIE(task) || IS_EXITING(task))
> return;
>
> - rdflags = ACTIVE() ? (QUIET|RETURN_ON_ERROR) :
> RETURN_ON_ERROR;
> -
> tc = task_to_context(task);
>
> if (!tc || !tc->mm_struct) /* probably a kernel thread */
>
> --
> Crash-utility mailing list
> Crash-utility@redhat.com
> https://www.redhat.com/mailman/listinfo/crash-utility

--
Crash-utility mailing list
Crash-utility@redhat.com
https://www.redhat.com/mailman/listinfo/crash-utility
 

Thread Tools




All times are GMT. The time now is 08:06 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org