FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.

» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Redhat > Cluster Development

LinkBack Thread Tools
Old 05-09-2008, 05:20 PM
Default Cluster Project branch, RHEL4, updated. gfs-kernel_2_6_9_76-54-g4a882ef

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Cluster Project".

http://sources.redhat.com/git/gitweb.cgi?p=cluster.git;a=commitdiff;h=4a882ef960 1cece3e5383dc22965902ed462f7e2

The branch, RHEL4 has been updated
via 4a882ef9601cece3e5383dc22965902ed462f7e2 (commit)
from b5ab5afac7d6cd8c696b46bacb022ae528d636fe (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 4a882ef9601cece3e5383dc22965902ed462f7e2
Author: Abhijith Das <adas@redhat.com>
Date: Fri May 9 12:00:05 2008 -0500

gfs-kernel: Workaround fix for bz 444912 (gfs_glock_is_locked_by_me problem)

This one-line fix, removes the assert warning. The behavior of the code is unchanged except that the assert warnings will no longer appear in the logs. This warning is tripped through the madvise syscall where control reaches the readpage function without the inode glock being held. We return -ENOSYS in such a case, disabling the madvise syscall.

A more elegant fix for RHEL5 gfs that supports the madvise syscall (bz 429343) could not be ported to RHEL4 because AOP_TRUNCATED_PAGE is not available in RHEL4.


Summary of changes:
gfs-kernel/src/gfs/ops_address.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/gfs-kernel/src/gfs/ops_address.c b/gfs-kernel/src/gfs/ops_address.c
index af5b3b3..fb17133 100644
--- a/gfs-kernel/src/gfs/ops_address.c
+++ b/gfs-kernel/src/gfs/ops_address.c
@@ -283,7 +283,7 @@ gfs_readpage(struct file *file, struct page *page)


- if (gfs_assert_warn(sdp, gfs_glock_is_locked_by_me(ip->i_gl))) {
+ if (!gfs_glock_is_locked_by_me(ip->i_gl)) {
return -ENOSYS;

Cluster Project

Thread Tools

All times are GMT. The time now is 10:36 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org