Linux Archive

Linux Archive (http://www.linux-archive.org/)
-   Cluster Development (http://www.linux-archive.org/cluster-development/)
-   -   gfs2: Fix an unchecked error from gfs2_rs_alloc (http://www.linux-archive.org/cluster-development/712406-gfs2-fix-unchecked-error-gfs2_rs_alloc.html)

Steven Whitehouse 10-15-2012 11:14 AM

gfs2: Fix an unchecked error from gfs2_rs_alloc
 
Hi,

All 3 patches now in the -nmw tree. Thanks,

Steve.

On Fri, 2012-10-12 at 16:45 +0100, Andrew Price wrote:
> Check the return value of gfs2_rs_alloc(ip) and avoid a possible null
> pointer dereference.
>
> Signed-off-by: Andrew Price <anprice@redhat.com>
> ---
> fs/gfs2/quota.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/fs/gfs2/quota.c b/fs/gfs2/quota.c
> index 40c4b0d..c5af8e1 100644
> --- a/fs/gfs2/quota.c
> +++ b/fs/gfs2/quota.c
> @@ -497,8 +497,11 @@ int gfs2_quota_hold(struct gfs2_inode *ip, u32 uid, u32 gid)
> struct gfs2_quota_data **qd;
> int error;
>
> - if (ip->i_res == NULL)
> - gfs2_rs_alloc(ip);
> + if (ip->i_res == NULL) {
> + error = gfs2_rs_alloc(ip);
> + if (error)
> + return error;
> + }
>
> qd = ip->i_res->rs_qa_qd;
>


All times are GMT. The time now is 10:42 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.