GFS2: eliminate redundant log flush
----- Original Message -----
| What ensures that the revokes are on disk?
| This one looks like it is probably correct, however there is no point
| adding a comment to refer to code that has just been removed. Just
| remove that call and put the explanation in the patch description, or
| maybe include just a short comment so say that there is a log flush
| implicit in the write_inode_now() call,
You're right about the revokes; my bad. Here is a respin, with just
a comment in the patch rather than in the code:
In function gfs2_evict_inode, there was a call to gfs2_log_flush
that is unnecessary because it immediately calls write_inode_now
which makes another call to gfs2_log_flush. This patch eliminates
the redundant log flush.
Red Hat GFS
Signed-off-by: Bob Peterson <firstname.lastname@example.org>
diff --git a/fs/gfs2/super.c b/fs/gfs2/super.c
index 3cbac68..ba4fde5 100644
@@ -1542,7 +1542,6 @@ static void gfs2_evict_inode(struct inode *inode)
- gfs2_log_flush(sdp, ip->i_gl);
|All times are GMT. The time now is 10:09 AM.|
VBulletin, Copyright ©2000 - 2013, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.