Linux Archive

Linux Archive (http://www.linux-archive.org/)
-   Cluster Development (http://www.linux-archive.org/cluster-development/)
-   -   GFS2: Fix quota adjustment return code (http://www.linux-archive.org/cluster-development/667150-gfs2-fix-quota-adjustment-return-code.html)

Bob Peterson 05-15-2012 06:51 PM

GFS2: Fix quota adjustment return code
 
Hi,

This patch changes function gfs2_adjust_quota so that it properly
returns a good (zero) return code on the normal path through the code.
Without this, mounting GFS2 with -o quota=account periodically gave
this error message: GFS2: fsid=cluster:fs: gfs2_quotad: sync error -5

Regards,

Bob Peterson
Red Hat File Systems

Signed-off-by: Bob Peterson <rpeterso@redhat.com>
---
diff --git a/fs/gfs2/quota.c b/fs/gfs2/quota.c
index 02df0de..197cc2d 100644
--- a/fs/gfs2/quota.c
+++ b/fs/gfs2/quota.c
@@ -744,7 +744,7 @@ get_a_page:
i_size_write(inode, size);
inode->i_mtime = inode->i_atime = CURRENT_TIME;
mark_inode_dirty(inode);
- return err;
+ return 0;

unlock_out:
unlock_page(page);

Steven Whitehouse 05-16-2012 12:28 PM

GFS2: Fix quota adjustment return code
 
Hi,

On Tue, 2012-05-15 at 14:51 -0400, Bob Peterson wrote:
> Hi,
>
> This patch changes function gfs2_adjust_quota so that it properly
> returns a good (zero) return code on the normal path through the code.
> Without this, mounting GFS2 with -o quota=account periodically gave
> this error message: GFS2: fsid=cluster:fs: gfs2_quotad: sync error -5
>
Now in the -nmw git tree. Thanks,

Steve.

> Regards,
>
> Bob Peterson
> Red Hat File Systems
>
> Signed-off-by: Bob Peterson <rpeterso@redhat.com>
> ---
> diff --git a/fs/gfs2/quota.c b/fs/gfs2/quota.c
> index 02df0de..197cc2d 100644
> --- a/fs/gfs2/quota.c
> +++ b/fs/gfs2/quota.c
> @@ -744,7 +744,7 @@ get_a_page:
> i_size_write(inode, size);
> inode->i_mtime = inode->i_atime = CURRENT_TIME;
> mark_inode_dirty(inode);
> - return err;
> + return 0;
>
> unlock_out:
> unlock_page(page);
>

Steven Whitehouse 05-17-2012 12:23 PM

GFS2: Fix quota adjustment return code
 
From: Bob Peterson <rpeterso@redhat.com>

This patch changes function gfs2_adjust_quota so that it properly
returns a good (zero) return code on the normal path through the code.
Without this, mounting GFS2 with -o quota=account periodically gave
this error message: GFS2: fsid=cluster:fs: gfs2_quotad: sync error -5

Signed-off-by: Bob Peterson <rpeterso@redhat.com>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>

diff --git a/fs/gfs2/quota.c b/fs/gfs2/quota.c
index 45d9171..b97178e 100644
--- a/fs/gfs2/quota.c
+++ b/fs/gfs2/quota.c
@@ -744,7 +744,7 @@ get_a_page:
i_size_write(inode, size);
inode->i_mtime = inode->i_atime = CURRENT_TIME;
mark_inode_dirty(inode);
- return err;
+ return 0;

unlock_out:
unlock_page(page);
--
1.7.4


All times are GMT. The time now is 01:00 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.