Linux Archive

Linux Archive (http://www.linux-archive.org/)
-   Cluster Development (http://www.linux-archive.org/cluster-development/)
-   -   fsck.gfs2: Fix unchecked malloc in gfs2_dup_set() (http://www.linux-archive.org/cluster-development/623167-fsck-gfs2-fix-unchecked-malloc-gfs2_dup_set.html)

Steven Whitehouse 01-20-2012 12:40 PM

fsck.gfs2: Fix unchecked malloc in gfs2_dup_set()
 
Hi,

Those look good to me,

Steve.

On Fri, 2012-01-20 at 12:39 +0000, Andrew Price wrote:
> Spotted by coverity: Dereferencing a pointer that might be null "data"
> when calling "memset"
>
> Signed-off-by: Andrew Price <anprice@redhat.com>
> ---
> gfs2/fsck/util.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/gfs2/fsck/util.c b/gfs2/fsck/util.c
> index f37fe7d..6c80ae8 100644
> --- a/gfs2/fsck/util.c
> +++ b/gfs2/fsck/util.c
> @@ -253,6 +253,10 @@ static struct duptree *gfs2_dup_set(uint64_t dblock, int create)
> if (!create)
> return NULL;
> data = malloc(sizeof(struct duptree));
> + if (data == NULL) {
> + log_crit( _("Unable to allocate duptree structure
"));
> + return NULL;
> + }
> dups_found++;
> memset(data, 0, sizeof(struct duptree));
> /* Add new node and rebalance tree. */


All times are GMT. The time now is 10:31 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.