FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Redhat > Cluster Development

 
 
LinkBack Thread Tools
 
Old 01-11-2012, 05:43 PM
Abhijith Das
 
Default libgfs2: Set errno in dirent_alloc and use dir_add consistently

Hi,

ACK all 8 patches.

Cheers!
--Abhi

----- Original Message -----
> From: "Andrew Price" <anprice@redhat.com>
> To: cluster-devel@redhat.com
> Sent: Wednesday, January 11, 2012 12:21:22 PM
> Subject: [Cluster-devel] [PATCH 8/8] libgfs2: Set errno in dirent_alloc and use dir_add consistently
>
> Initially spotted by coverity: "error" is passed to a parameter that
> cannot be negative.
>
> It turned out that dirent_alloc was returning -ENOSPC and some
> calling
> code (via dir_add) was assuming that errno was set. Other code was
> assuming that dir_add returned -errno. This patch changes
> dirent_alloc
> to set errno and return -1 and also updates the code which calls
> dir_add
> to use errno.
>
> Signed-off-by: Andrew Price <anprice@redhat.com>
 

Thread Tools




All times are GMT. The time now is 06:50 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org