FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Redhat > Cluster Development

 
 
LinkBack Thread Tools
 
Old 11-23-2011, 09:15 AM
"Fabio M. Di Nitto"
 
Default libcman: fix possible memory leak

Spotted by Coverity Scan

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>
---
:100644 100644 fbf5bf8... 5b015f0... M cman/lib/libcman.c
cman/lib/libcman.c | 12 ++++++++++--
1 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/cman/lib/libcman.c b/cman/lib/libcman.c
index fbf5bf8..5b015f0 100644
--- a/cman/lib/libcman.c
+++ b/cman/lib/libcman.c
@@ -533,16 +533,24 @@ int cman_dispatch(cman_handle_t handle, int flags)
{
len = read(h->fd, bufptr+offset, header->length-offset);
if (len == 0) {
+ if (bufptr != buf)
+ free(bufptr);
errno = EHOSTDOWN;
return -1;
}

if (len < 0 &&
- (errno == EINTR || errno == EAGAIN))
+ (errno == EINTR || errno == EAGAIN)) {
+ if (bufptr != buf)
+ free(bufptr);
return 0;
+ }

- if (len < 0)
+ if (len < 0) {
+ if (bufptr != buf)
+ free(bufptr);
return -1;
+ }
offset += len;
}

--
1.7.4.4
 

Thread Tools




All times are GMT. The time now is 07:49 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org