Linux Archive

Linux Archive (http://www.linux-archive.org/)
-   Cluster Development (http://www.linux-archive.org/cluster-development/)
-   -   mkfs: remove duplicated code to ask yes/no question (http://www.linux-archive.org/cluster-development/581052-mkfs-remove-duplicated-code-ask-yes-no-question.html)

Steven Whitehouse 09-28-2011 09:20 AM

mkfs: remove duplicated code to ask yes/no question
 
Hi,

Modulo my comment on the first patch, otherwise these look good,

Steve.

On Tue, 2011-09-27 at 13:08 -0300, Carlos Maiolino wrote:
> This patch takes advantage of the are_you_sure() function
> to ask a yes/no question within verify_bsize() function
>
> Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>
> ---
> gfs2/mkfs/main_mkfs.c | 9 +--------
> 1 files changed, 1 insertions(+), 8 deletions(-)
>
> diff --git a/gfs2/mkfs/main_mkfs.c b/gfs2/mkfs/main_mkfs.c
> index 8802ef7..0bd1410 100644
> --- a/gfs2/mkfs/main_mkfs.c
> +++ b/gfs2/mkfs/main_mkfs.c
> @@ -350,14 +350,7 @@ static void verify_bsize(struct gfs2_sbd *sdp)
> if (sdp->override)
> return;
>
> - printf( _("
Are you sure you want to proceed? [y/n] "));
> - if(!fgets(input, 32, stdin))
> - die( _("unable to read from stdin
"));
> -
> - if (input[0] != 'y')
> - die( _("aborted
"));
> - else
> - printf("
");
> + are_you_sure();
> }
> }
>


All times are GMT. The time now is 08:35 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.