FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Redhat > Cluster Development

 
 
LinkBack Thread Tools
 
Old 09-06-2011, 12:43 PM
Steven Whitehouse
 
Default gfs_controld: Remove dead code from loop()

Hi,

Those all look good to me,

Steve.

On Tue, 2011-09-06 at 13:00 +0100, Andrew Price wrote:
> This patch removes an if statement where the true branch is never taken.
> At this point in the code, poll_timeout could only be 500 or -1.
>
> Signed-off-by: Andrew Price <anprice@redhat.com>
> ---
> group/gfs_controld/main.c | 3 ---
> 1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/group/gfs_controld/main.c b/group/gfs_controld/main.c
> index 252965a..aa38839 100644
> --- a/group/gfs_controld/main.c
> +++ b/group/gfs_controld/main.c
> @@ -1286,9 +1286,6 @@ static void loop(void)
> if (dmsetup_wait) {
> if (poll_timeout == -1)
> poll_timeout = 1000;
> - } else {
> - if (poll_timeout == 1000)
> - poll_timeout = -1;
> }
> }
> query_unlock();
 
Old 09-06-2011, 02:36 PM
David Teigland
 
Default gfs_controld: Remove dead code from loop()

On Tue, Sep 06, 2011 at 01:00:16PM +0100, Andrew Price wrote:
> This patch removes an if statement where the true branch is never taken.
> At this point in the code, poll_timeout could only be 500 or -1.
>
> Signed-off-by: Andrew Price <anprice@redhat.com>
> ---
> group/gfs_controld/main.c | 3 ---
> 1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/group/gfs_controld/main.c b/group/gfs_controld/main.c
> index 252965a..aa38839 100644
> --- a/group/gfs_controld/main.c
> +++ b/group/gfs_controld/main.c
> @@ -1286,9 +1286,6 @@ static void loop(void)
> if (dmsetup_wait) {
> if (poll_timeout == -1)
> poll_timeout = 1000;
> - } else {
> - if (poll_timeout == 1000)
> - poll_timeout = -1;

ok

> }
> }
> query_unlock();
> --
> 1.7.6
 

Thread Tools




All times are GMT. The time now is 05:40 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org