FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Redhat > Cluster Development

 
 
LinkBack Thread Tools
 
Old 04-20-2011, 03:42 PM
Matt Clark
 
Default Cleanup of fence_xenapi patches. Added copyright information to doc/COPYRIGHT. Fixed static reference to lib directory in fence_xenapi.py. Fixed static reference to RELEASE_VERSION and BUILD_DATE in fence_xenapi.py.

Patch 5/5 only touches the 3 files listed in your original email.
The script fence_xenapi.py is the script that does the fencing, not the library.
XenAPI.py is the underlying library which is now located in lib/ as of patch 4/50004-Clean-up-of-fence_xenapi-patches.patch: fence/agents/lib/XenAPI.py.py | *209 +++++++++++++++++++++++++++++++++++++++++0004-Clean-up-of-fence_xenapi-patches.patch: fence/agents/xenapi/XenAPI.py | *209 -----------------------------------------
Unless I am missing something... Which is quite possible.

> Date: Wed, 20 Apr 2011 17:32:23 +0200
> From: fdinitto@redhat.com
> To: cluster-devel@redhat.com
> Subject: Re: [Cluster-devel] [PATCH 5/5] Cleanup of fence_xenapi patches. Added copyright information to doc/COPYRIGHT. Fixed static reference to lib directory in fence_xenapi.py. Fixed static reference to RELEASE_VERSION and BUILD_DATE in fence_xenapi.py.
>
> On 04/20/2011 05:12 PM, Matt Clark wrote:
> > Patch 4/5 takes care of that. At least it should have...
> >
>
> Then something is wrong with the patch ordering because 4/4 renames but
> 5 changes the old path?
>
> Fabio
>
> >> Date: Wed, 20 Apr 2011 16:04:46 +0200
> >> From: fdinitto@redhat.com
> >> To: cluster-devel@redhat.com
> >> Subject: Re: [Cluster-devel] [PATCH 5/5] Cleanup of fence_xenapi
> > patches. Added copyright information to doc/COPYRIGHT. Fixed static
> > reference to lib directory in fence_xenapi.py. Fixed static reference to
> > RELEASE_VERSION and BUILD_DATE in fence_xenapi.py.
> >>
> >> On 04/20/2011 01:51 PM, Matt Clark wrote:
> >> > ---
> >> > doc/COPYRIGHT | 4 ++++
> >> > fence/agents/lib/Makefile.am | 4 ++--
> >> > fence/agents/xenapi/fence_xenapi.py | 12 ++++++++----
> >> > 3 files changed, 14 insertions(+), 6 deletions(-)
> >>
> >> You forgot to move the xenapi file in lib/ ?
> >>
> >> Fabio
> >>
>
 
Old 04-20-2011, 03:57 PM
"Fabio M. Di Nitto"
 
Default Cleanup of fence_xenapi patches. Added copyright information to doc/COPYRIGHT. Fixed static reference to lib directory in fence_xenapi.py. Fixed static reference to RELEASE_VERSION and BUILD_DATE in fence_xenapi.py.

On 04/20/2011 05:42 PM, Matt Clark wrote:
> Patch 5/5 only touches the 3 files listed in your original email.
>
> The script fence_xenapi.py is the script that does the fencing, not the
> library.
>
> XenAPI.py is the underlying library which is now located in lib/ as of
> patch 4/5
> 0004-Clean-up-of-fence_xenapi-patches.patch:
> fence/agents/lib/XenAPI.py.py | 209
> +++++++++++++++++++++++++++++++++++++++++
> 0004-Clean-up-of-fence_xenapi-patches.patch:
> fence/agents/xenapi/XenAPI.py | 209
> -----------------------------------------
>
> Unless I am missing something... Which is quite possible.

Whooops... I got confused by the two names...

Ok time for me to go on vacation and relax.

Marek, can you please merge the patchset when you are around
(git am ..) ?

Thanks
Fabio
 

Thread Tools




All times are GMT. The time now is 07:54 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org