Linux Archive

Linux Archive (http://www.linux-archive.org/)
-   Cluster Development (http://www.linux-archive.org/cluster-development/)
-   -   GFS2: Pre-pull patch posting (merge window) (http://www.linux-archive.org/cluster-development/501348-gfs2-pre-pull-patch-posting-merge-window.html)

Steven Whitehouse 03-15-2011 08:11 AM

GFS2: Pre-pull patch posting (merge window)
 
Hi,

The most interesting "feature" in this patch set is the RCU glock
patch which has been a long time coming, but is finally here. That
patch contains most of the changes this time. The other patches ins
this set are mostly smaller bug fixes and performance improvements.

Steve.

Steven Whitehouse 05-19-2011 08:46 AM

GFS2: Pre-pull patch posting (merge window)
 
Hi,

This time, most of the GFS2 patches are code clean up, although there
are a few bug fixes (fallocate/ail writeback/end of life inodes/nlink) and
some new features (new tracepoint & tracing flags, using the UUID field
in the generic superblock).

The changes can be broadly divided into three sets:

1. Bob's directory code clean up
2. My fsync/ail writeback fixes & clean up
3. inode.c/ops_inode.c clean up

Steve.

Steven Whitehouse 07-22-2011 09:16 AM

GFS2: Pre-pull patch posting (merge window)
 
Hi,

Not a lot new this time... the addition of a cache for the directory hash table
improve directory read/lookup speed, automatic adjustment of the glock hold
time improves performance for some contention corner cases. S_NOSEC support
is another performance related change, plus a nice clean up from Eric
Sandeen,

Steve.

Steven Whitehouse 10-24-2011 12:48 PM

GFS2: Pre-pull patch posting (merge window)
 
Hi,

Since the merge window is upon us, here is the current content of
the GFS2 git tree. A few things will be help back to the following
merge window in order to ensure a greater test time, but those currently
in the tree are ready for the current window.

Recently I've reconstituted the GFS2 git tree, so it can be pulled
(via http) from:

http://sucs.org/~rohan/git/gfs2-3.0-nmw

and viewed via gitweb at:

http://sucs.org/gitweb/

This is thanks to the Swansea University Computer Society for providing
a temporary (or possibly permanent) home for the GFS2 git trees. Please
treat their server kindly as this will only continue while it doesn't
generate too much traffic. I figure that there will not be too many
people pulling the GFS2 tree at once, but we'll see.

Some highlights of the current patch set:
o Reduction in code of approx 400 lines
o Big clean up (and speed up) in the resource group code
- This is a nice base to build some forthcoming improvements on
- It should improve performance with multi-threaded workloads
o Some left-over fsync/writeback changes
o Improvements to readahead when deallocating large directories

Any questions/concerns then please let me know as usual,

Steve.

Steven Whitehouse 01-05-2012 10:51 AM

GFS2: Pre-pull patch posting (merge window)
 
Hi,

The main feature this time is clean up around the allocation and
resource group code. Otherwise the remainder is mostly small
bug fixes.

I've held back the glock stats patch and that will probably be
ready for the following merge window with a bit of luck,

Steve.

Steven Whitehouse 03-19-2012 09:25 AM

GFS2: Pre-pull patch posting (merge window)
 
Hi,

Not a huge number of patches this time. Some notable new features
though:
- Glock stats gathering (v. useful for performance analysis)
- FITRIM ioctl support
- Sorting the ordered write list (big performance increase when the workload
doesn't result in the write requests being nicely ordered to start with)

Plus a few clean ups, and bug fixes in addition,

Steve.

Steven Whitehouse 03-19-2012 01:59 PM

GFS2: Pre-pull patch posting (merge window)
 
Hi,

On Mon, 2012-03-19 at 07:45 -0700, Randy Dunlap wrote:
> On 03/19/2012 03:25 AM, Steven Whitehouse wrote:
>
> > Hi,
> >
> > Not a huge number of patches this time. Some notable new features
> > though:
> > - Glock stats gathering (v. useful for performance analysis)
> > - FITRIM ioctl support
> > - Sorting the ordered write list (big performance increase when the workload
> > doesn't result in the write requests being nicely ordered to start with)
> >
> > Plus a few clean ups, and bug fixes in addition,
>
>
>
> Hi,
>
> I reported a build error in linux-next 20120313, but it appears
> that mainline also needs the fix (when it's ready) since mainline
> gfs2 Kconfig selects DLM_SCTP, which does not exist.
>
> https://lkml.org/lkml/2012/3/13/456
>

Does the following fix the problem? If so then I'll roll that into the
tree before it gets pushed,

Steve.

diff --git a/fs/gfs2/Kconfig b/fs/gfs2/Kconfig
index c465ae0..f4e1c60 100644
--- a/fs/gfs2/Kconfig
+++ b/fs/gfs2/Kconfig
@@ -4,7 +4,7 @@ config GFS2_FS
select DLM if GFS2_FS_LOCKING_DLM
select CONFIGFS_FS if GFS2_FS_LOCKING_DLM
select SYSFS if GFS2_FS_LOCKING_DLM
- select IP_SCTP if DLM_SCTP
+ select IP_SCTP if GFS2_FS_LOCKING_DLM
select FS_POSIX_ACL
select CRC32
select QUOTACTL

Steven Whitehouse 03-19-2012 02:34 PM

GFS2: Pre-pull patch posting (merge window)
 
Hi,

On Mon, 2012-03-19 at 08:18 -0700, Randy Dunlap wrote:
> On 03/19/2012 07:59 AM, Steven Whitehouse wrote:
>
> > Hi,
> >
> > On Mon, 2012-03-19 at 07:45 -0700, Randy Dunlap wrote:
> >> On 03/19/2012 03:25 AM, Steven Whitehouse wrote:
> >>
> >>> Hi,
> >>>
> >>> Not a huge number of patches this time. Some notable new features
> >>> though:
> >>> - Glock stats gathering (v. useful for performance analysis)
> >>> - FITRIM ioctl support
> >>> - Sorting the ordered write list (big performance increase when the workload
> >>> doesn't result in the write requests being nicely ordered to start with)
> >>>
> >>> Plus a few clean ups, and bug fixes in addition,
> >>
> >>
> >>
> >> Hi,
> >>
> >> I reported a build error in linux-next 20120313, but it appears
> >> that mainline also needs the fix (when it's ready) since mainline
> >> gfs2 Kconfig selects DLM_SCTP, which does not exist.
> >>
> >> https://lkml.org/lkml/2012/3/13/456
> >>
> >
> > Does the following fix the problem? If so then I'll roll that into the
> > tree before it gets pushed,
> >
>
> No, that's not sufficient:
>
> warning: (GFS2_FS) selects DLM which has unmet direct dependencies (EXPERIMENTAL && INET && SYSFS && CONFIGFS_FS && (IPV6 || IPV6=n))
> warning: (DLM && GFS2_FS) selects IP_SCTP which has unmet direct dependencies (NET && INET && EXPERIMENTAL && (IPV6 || IPV6=n))
>
> and
>
> ERROR: "crc32c" [net/sctp/sctp.ko] undefined!
>
>
Hmm, ok. I'll look at this again. I'm not sure why DLM is still calling
itself EXPERIMENTAL since thats long since not been the case, maybe SCTP
still is, but I don't think GFS2 should be selecting EXPERIMENTAL
directly, anyway. It is rather easy to tie ones' self in knots with this
config language.... since GFS2_FS_LOCKING_DLM depends on NET && INET &&
(IPV6 || IPV6=n) && HOTPLUG then all those other deps must presumably be
set anyway, so I don't understand quite why DLM doesn't have those
available to it.

I'll dig around a bit and see if I can figure out whats going on here,

Steve.


>
>
> >
> > diff --git a/fs/gfs2/Kconfig b/fs/gfs2/Kconfig
> > index c465ae0..f4e1c60 100644
> > --- a/fs/gfs2/Kconfig
> > +++ b/fs/gfs2/Kconfig
> > @@ -4,7 +4,7 @@ config GFS2_FS
> > select DLM if GFS2_FS_LOCKING_DLM
> > select CONFIGFS_FS if GFS2_FS_LOCKING_DLM
> > select SYSFS if GFS2_FS_LOCKING_DLM
> > - select IP_SCTP if DLM_SCTP
> > + select IP_SCTP if GFS2_FS_LOCKING_DLM
> > select FS_POSIX_ACL
> > select CRC32
> > select QUOTACTL
> >
> >
>
>
>

Steven Whitehouse 03-20-2012 08:47 AM

GFS2: Pre-pull patch posting (merge window)
 
Hi,

On Mon, 2012-03-19 at 08:18 -0700, Randy Dunlap wrote:
> On 03/19/2012 07:59 AM, Steven Whitehouse wrote:
>
> > Hi,
> >
> > On Mon, 2012-03-19 at 07:45 -0700, Randy Dunlap wrote:
> >> On 03/19/2012 03:25 AM, Steven Whitehouse wrote:
> >>
> >>> Hi,
> >>>
> >>> Not a huge number of patches this time. Some notable new features
> >>> though:
> >>> - Glock stats gathering (v. useful for performance analysis)
> >>> - FITRIM ioctl support
> >>> - Sorting the ordered write list (big performance increase when the workload
> >>> doesn't result in the write requests being nicely ordered to start with)
> >>>
> >>> Plus a few clean ups, and bug fixes in addition,
> >>
> >>
> >>
> >> Hi,
> >>
> >> I reported a build error in linux-next 20120313, but it appears
> >> that mainline also needs the fix (when it's ready) since mainline
> >> gfs2 Kconfig selects DLM_SCTP, which does not exist.
> >>
> >> https://lkml.org/lkml/2012/3/13/456
> >>
> >
> > Does the following fix the problem? If so then I'll roll that into the
> > tree before it gets pushed,
> >
>
> No, that's not sufficient:
>
> warning: (GFS2_FS) selects DLM which has unmet direct dependencies (EXPERIMENTAL && INET && SYSFS && CONFIGFS_FS && (IPV6 || IPV6=n))
> warning: (DLM && GFS2_FS) selects IP_SCTP which has unmet direct dependencies (NET && INET && EXPERIMENTAL && (IPV6 || IPV6=n))
>
> and
>
> ERROR: "crc32c" [net/sctp/sctp.ko] undefined!
>
>
Since the pending patch set doesn't affect the Kconfig at all, I don't
think that this issue needs to hold up merging the GFS2 tree. We'll
follow up with a fix for this later on,

Steve.

David Teigland 03-23-2012 06:41 PM

GFS2: Pre-pull patch posting (merge window)
 
> on i386:
>
> ERROR: "sctp_do_peeloff" [fs/dlm/dlm.ko] undefined!
>
>
> GFS2_FS selects DLM (if GFS2_FS_LOCKING_DLM, which is enabled).
> GFS2_FS selects IP_SCTP if DLM_SCTP, which is not enabled and not
> used anywhere else in the kernel tree AFAICT.
> DLM just always selects IP_SCTP.

Here's what we have now:

config GFS2_FS
tristate "GFS2 file system support"
depends on (64BIT || LBDAF)
select DLM if GFS2_FS_LOCKING_DLM
select CONFIGFS_FS if GFS2_FS_LOCKING_DLM
select SYSFS if GFS2_FS_LOCKING_DLM
select IP_SCTP if DLM_SCTP
select FS_POSIX_ACL
select CRC32
select QUOTACTL

menuconfig DLM
tristate "Distributed Lock Manager (DLM)"
depends on EXPERIMENTAL && INET
depends on SYSFS && CONFIGFS_FS && (IPV6 || IPV6=n)
select IP_SCTP

Why does gfs2 Kconfig bother with SCTP at all? It seems that line should
just be removed. I'll also remove EXPERIMENTAL. I don't understand the
vagaries of Kconfig, so a dumb question, how could sctp_do_peeloff
possibly be undefined if we're selecting SCTP.


All times are GMT. The time now is 08:58 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.