FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Redhat > Cluster Development

 
 
LinkBack Thread Tools
 
Old 01-04-2011, 08:00 AM
Jan Friesse
 
Default cman: Fix udpb handling in cman-preconfig

Lon,
even it may "logically" seemed that original code is incorrect and your
patch make sense, it's not the case.

Actually, corosync has 3 transports:
udp, udpu and iba.

Broadcast is same transport as udp but only has broadcast flag set on.

In other words, this patch is not correct.

Regards,
Honza

Lon Hohberger wrote:
> Signed-off-by: Lon Hohberger <lhh@redhat.com>
> ---
> cman/daemon/cman-preconfig.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/cman/daemon/cman-preconfig.c b/cman/daemon/cman-preconfig.c
> index 5239d89..5d608a7 100644
> --- a/cman/daemon/cman-preconfig.c
> +++ b/cman/daemon/cman-preconfig.c
> @@ -286,7 +286,7 @@ static int add_ifaddr(struct objdb_iface_ver0 *objdb, char *mcast, char *ifaddr,
> int ret = 0;
> const char *tx_mech_to_str[] = {
> [TX_MECH_UDP] = "udp",
> - [TX_MECH_UDPB] = "udp",
> + [TX_MECH_UDPB] = "udpb",
> [TX_MECH_UDPU] = "udpu",
> [TX_MECH_RDMA] = "iba",
> };
 

Thread Tools




All times are GMT. The time now is 08:56 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org