FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Redhat > Cluster Development

 
 
LinkBack Thread Tools
 
Old 11-16-2010, 10:50 AM
Jan Kara
 
Default Ocfs2: handle hole punching via fallocate properly

On Mon 15-11-10 12:05:20, Josef Bacik wrote:
> This patch just makes ocfs2 use its UNRESERVP ioctl when we get the hole punch
> flag in fallocate. I didn't test it, but it seems simple enough. Thanks,
>
> Signed-off-by: Josef Bacik <josef@redhat.com>
You might want to directly CC Joel Becker <Joel.Becker@oracle.com> who
maintains OCFS2. Otherwise the patch looks OK so you can add
Acked-by: Jan Kara <jack@suse.cz>
for what it's worth .

Honza
> ---
> fs/ocfs2/file.c | 10 ++++++++--
> 1 files changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c
> index 77b4c04..181ae52 100644
> --- a/fs/ocfs2/file.c
> +++ b/fs/ocfs2/file.c
> @@ -1992,6 +1992,7 @@ static long ocfs2_fallocate(struct inode *inode, int mode, loff_t offset,
> struct ocfs2_super *osb = OCFS2_SB(inode->i_sb);
> struct ocfs2_space_resv sr;
> int change_size = 1;
> + int cmd = OCFS2_IOC_RESVSP64;
>
> if (!ocfs2_writes_unwritten_extents(osb))
> return -EOPNOTSUPP;
> @@ -2002,12 +2003,17 @@ static long ocfs2_fallocate(struct inode *inode, int mode, loff_t offset,
> if (mode & FALLOC_FL_KEEP_SIZE)
> change_size = 0;
>
> + if (mode & FALLOC_FL_PUNCH_HOLE) {
> + cmd = OCFS2_IOC_UNRESVSP64;
> + change_size = 0;
> + }
> +
> sr.l_whence = 0;
> sr.l_start = (s64)offset;
> sr.l_len = (s64)len;
>
> - return __ocfs2_change_file_space(NULL, inode, offset,
> - OCFS2_IOC_RESVSP64, &sr, change_size);
> + return __ocfs2_change_file_space(NULL, inode, offset, cmd, &sr,
> + change_size);
> }
>
> int ocfs2_check_range_for_refcount(struct inode *inode, loff_t pos,
> --
> 1.6.6.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
 
Old 11-17-2010, 10:27 PM
Joel Becker
 
Default Ocfs2: handle hole punching via fallocate properly

On Mon, Nov 15, 2010 at 12:05:20PM -0500, Josef Bacik wrote:
> This patch just makes ocfs2 use its UNRESERVP ioctl when we get the hole punch
> flag in fallocate. I didn't test it, but it seems simple enough. Thanks,
>
> Signed-off-by: Josef Bacik <josef@redhat.com>

Seems reasonable to me.
Acked-by: Joel Becker <joel.becker@oracle.com>

Joel

> ---
> fs/ocfs2/file.c | 10 ++++++++--
> 1 files changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c
> index 77b4c04..181ae52 100644
> --- a/fs/ocfs2/file.c
> +++ b/fs/ocfs2/file.c
> @@ -1992,6 +1992,7 @@ static long ocfs2_fallocate(struct inode *inode, int mode, loff_t offset,
> struct ocfs2_super *osb = OCFS2_SB(inode->i_sb);
> struct ocfs2_space_resv sr;
> int change_size = 1;
> + int cmd = OCFS2_IOC_RESVSP64;
>
> if (!ocfs2_writes_unwritten_extents(osb))
> return -EOPNOTSUPP;
> @@ -2002,12 +2003,17 @@ static long ocfs2_fallocate(struct inode *inode, int mode, loff_t offset,
> if (mode & FALLOC_FL_KEEP_SIZE)
> change_size = 0;
>
> + if (mode & FALLOC_FL_PUNCH_HOLE) {
> + cmd = OCFS2_IOC_UNRESVSP64;
> + change_size = 0;
> + }
> +
> sr.l_whence = 0;
> sr.l_start = (s64)offset;
> sr.l_len = (s64)len;
>
> - return __ocfs2_change_file_space(NULL, inode, offset,
> - OCFS2_IOC_RESVSP64, &sr, change_size);
> + return __ocfs2_change_file_space(NULL, inode, offset, cmd, &sr,
> + change_size);
> }
>
> int ocfs2_check_range_for_refcount(struct inode *inode, loff_t pos,
> --
> 1.6.6.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>

--

"Born under a bad sign.
I been down since I began to crawl.
If it wasn't for bad luck,
I wouldn't have no luck at all."

Joel Becker
Senior Development Manager
Oracle
E-mail: joel.becker@oracle.com
Phone: (650) 506-8127
 

Thread Tools




All times are GMT. The time now is 12:57 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org