FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Redhat > Cluster Development

 
 
LinkBack Thread Tools
 
Old 01-21-2008, 08:10 AM
Steven Whitehouse
 
Default Lockup on error

Hi,

On Sat, 2008-01-19 at 21:50 -0600, Bob Peterson wrote:
> Hi,
>
> I spotted this bug while I was digging around. Looks like it could cause
> a lockup in some rare error condition.
>
> Regards,
>
> Bob Peterson
> --
> Signed-off-by: Bob Peterson <rpeterso@redhat.com>
> --
> fs/gfs2/inode.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
Now in the -nmw git tree. Thanks,

Steve.

> diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c
> index c84764a..728d316 100644
> --- a/fs/gfs2/inode.c
> +++ b/fs/gfs2/inode.c
> @@ -860,7 +860,7 @@ static int link_dinode(struct gfs2_inode *dip, const struct qstr *name,
>
> error = alloc_required = gfs2_diradd_alloc_required(&dip->i_inode, name);
> if (alloc_required < 0)
> - goto fail;
> + goto fail_quota_locks;
> if (alloc_required) {
> error = gfs2_quota_check(dip, dip->i_inode.i_uid, dip->i_inode.i_gid);
> if (error)
>
>
 
Old 01-21-2008, 08:22 AM
 
Default Lockup on error

From: Bob Peterson <rpeterso@redhat.com>

I spotted this bug while I was digging around. Looks like it could cause
a lockup in some rare error condition.

Signed-off-by: Bob Peterson <rpeterso@redhat.com>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>

diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c
index c84764a..728d316 100644
--- a/fs/gfs2/inode.c
+++ b/fs/gfs2/inode.c
@@ -860,7 +860,7 @@ static int link_dinode(struct gfs2_inode *dip, const struct qstr *name,

error = alloc_required = gfs2_diradd_alloc_required(&dip->i_inode, name);
if (alloc_required < 0)
- goto fail;
+ goto fail_quota_locks;
if (alloc_required) {
error = gfs2_quota_check(dip, dip->i_inode.i_uid, dip->i_inode.i_gid);
if (error)
--
1.5.1.2
 

Thread Tools




All times are GMT. The time now is 08:43 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org