Hi guys,

in certain situations where gfs2 init scripts are not used to umount gfs2
volume, we endup with umount.gfs2 being invoked with -r option and this
fails because we don't know what to do with this option.


The patch simply ack the option and ignores it for now allowing a reboot
process to keep going.


Please ACK or apply.

Fabio

Index: umount.gfs2.c
================================================== =================
RCS file: /cvs/cluster/cluster/gfs2/mount/umount.gfs2.c,v
retrieving revision 1.15
diff -u -r1.15 umount.gfs2.c
--- umount.gfs2.c 22 Aug 2007 08:58:46 -0000 1.15
+++ umount.gfs2.c 19 Jan 2008 05:54:22 -0000
@@ -52,7 +52,7 @@
/* FIXME: check for "quiet" option and don't print in that case */

while (cont) {
- optchar = getopt(argc, argv, "fhVvX:");
+ optchar = getopt(argc, argv, "fhVvX:r");

switch (optchar) {
case EOF:
@@ -79,6 +79,9 @@
print_version();
exit(EXIT_SUCCESS);

+ case 'r':
+ break; /* used by umount to remount ro if umount fails */
+
default:
break;
}

--
I'm going to make him an offer he can't refuse.

On Sat, Jan 19, 2008 at 06:58:17AM +0100, Fabio M. Di Nitto wrote:
>
> Hi guys,
>
> in certain situations where gfs2 init scripts are not used to umount gfs2
> volume, we endup with umount.gfs2 being invoked with -r option and this
> fails because we don't know what to do with this option.
>
> The patch simply ack the option and ignores it for now allowing a reboot
> process to keep going.
>
> Please ACK or apply.

ack