Linux Archive

Linux Archive (http://www.linux-archive.org/)
-   Cluster Development (http://www.linux-archive.org/cluster-development/)
-   -   Remove unneeded i_spin (http://www.linux-archive.org/cluster-development/35046-remove-unneeded-i_spin.html)

Bob Peterson 01-11-2008 06:31 PM

Remove unneeded i_spin
 
Hi,

This patch removes a vestigial variable "i_spin" from the gfs2_inode
structure. This not only saves us memory (>300000 of these in memory
for the oom test) it also saves us time because we don't have to
spend time initializing it (i.e. slightly better performance).

Regards,

Bob Peterson
Red Hat GFS

Signed-off-by: Bob Peterson <rpeterso@redhat.com>
--
fs/gfs2/incore.h | 1 -
fs/gfs2/main.c | 1 -
2 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/fs/gfs2/incore.h b/fs/gfs2/incore.h
index bd92a6d..1339996 100644
--- a/fs/gfs2/incore.h
+++ b/fs/gfs2/incore.h
@@ -267,7 +267,6 @@ struct gfs2_inode {
struct gfs2_alloc *i_alloc;
u64 i_last_rg_alloc;

- spinlock_t i_spin;
struct rw_semaphore i_rw_mutex;
};

diff --git a/fs/gfs2/main.c b/fs/gfs2/main.c
index 88686fc..9c7765c 100644
--- a/fs/gfs2/main.c
+++ b/fs/gfs2/main.c
@@ -29,7 +29,6 @@ static void gfs2_init_inode_once(struct kmem_cache *cachep, void *foo)
struct gfs2_inode *ip = foo;

inode_init_once(&ip->i_inode);
- spin_lock_init(&ip->i_spin);
init_rwsem(&ip->i_rw_mutex);
ip->i_alloc = NULL;
}

Steven Whitehouse 01-11-2008 08:07 PM

Remove unneeded i_spin
 
Hi,

Now in the -nmw git tree. Thanks,

Steve.


On Fri, 2008-01-11 at 13:31 -0600, Bob Peterson wrote:
> Hi,
>
> This patch removes a vestigial variable "i_spin" from the gfs2_inode
> structure. This not only saves us memory (>300000 of these in memory
> for the oom test) it also saves us time because we don't have to
> spend time initializing it (i.e. slightly better performance).
>
> Regards,
>
> Bob Peterson
> Red Hat GFS
>
> Signed-off-by: Bob Peterson <rpeterso@redhat.com>
> --
> fs/gfs2/incore.h | 1 -
> fs/gfs2/main.c | 1 -
> 2 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/fs/gfs2/incore.h b/fs/gfs2/incore.h
> index bd92a6d..1339996 100644
> --- a/fs/gfs2/incore.h
> +++ b/fs/gfs2/incore.h
> @@ -267,7 +267,6 @@ struct gfs2_inode {
> struct gfs2_alloc *i_alloc;
> u64 i_last_rg_alloc;
>
> - spinlock_t i_spin;
> struct rw_semaphore i_rw_mutex;
> };
>
> diff --git a/fs/gfs2/main.c b/fs/gfs2/main.c
> index 88686fc..9c7765c 100644
> --- a/fs/gfs2/main.c
> +++ b/fs/gfs2/main.c
> @@ -29,7 +29,6 @@ static void gfs2_init_inode_once(struct kmem_cache *cachep, void *foo)
> struct gfs2_inode *ip = foo;
>
> inode_init_once(&ip->i_inode);
> - spin_lock_init(&ip->i_spin);
> init_rwsem(&ip->i_rw_mutex);
> ip->i_alloc = NULL;
> }
>
>

01-21-2008 08:22 AM

Remove unneeded i_spin
 
From: Bob Peterson <rpeterso@redhat.com>

This patch removes a vestigial variable "i_spin" from the gfs2_inode
structure. This not only saves us memory (>300000 of these in memory
for the oom test) it also saves us time because we don't have to
spend time initializing it (i.e. slightly better performance).

Signed-off-by: Bob Peterson <rpeterso@redhat.com>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>

diff --git a/fs/gfs2/incore.h b/fs/gfs2/incore.h
index bd92a6d..1339996 100644
--- a/fs/gfs2/incore.h
+++ b/fs/gfs2/incore.h
@@ -267,7 +267,6 @@ struct gfs2_inode {
struct gfs2_alloc *i_alloc;
u64 i_last_rg_alloc;

- spinlock_t i_spin;
struct rw_semaphore i_rw_mutex;
};

diff --git a/fs/gfs2/main.c b/fs/gfs2/main.c
index 88686fc..9c7765c 100644
--- a/fs/gfs2/main.c
+++ b/fs/gfs2/main.c
@@ -29,7 +29,6 @@ static void gfs2_init_inode_once(struct kmem_cache *cachep, void *foo)
struct gfs2_inode *ip = foo;

inode_init_once(&ip->i_inode);
- spin_lock_init(&ip->i_spin);
init_rwsem(&ip->i_rw_mutex);
ip->i_alloc = NULL;
}
--
1.5.1.2


All times are GMT. The time now is 09:57 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.