FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Redhat > Cluster Development

 
 
LinkBack Thread Tools
 
Old 02-05-2010, 10:17 PM
Abhijith Das
 
Default - Bug 537201 - Better error reporting when mounting a gfs fs without enough journals

Hi,

We need this one-liner to signal the mount helper of the 'insufficient journals' condition.

Signed-off-by: Abhijith Das <adas@redhat.com>

diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c
index d405c38..a054b52 100644
--- a/fs/gfs2/ops_fstype.c
+++ b/fs/gfs2/ops_fstype.c
@@ -724,7 +724,7 @@ static int init_journal(struct gfs2_sbd *sdp, int undo)
goto fail;
}

- error = -EINVAL;
+ error = -EUSERS;
if (!gfs2_jindex_size(sdp)) {
fs_err(sdp, "no journals!
");
goto fail_jindex;
 
Old 02-05-2010, 10:25 PM
Abhijith Das
 
Default - Bug 537201 - Better error reporting when mounting a gfs fs without enough journals

Please ignore the previous patch. The patch inlining didn't work right. Here's the unmangled one.

--Abhi

----- "Abhijith Das" <adas@redhat.com> wrote:

> From: "Abhijith Das" <adas@redhat.com>
> To: "cluster-devel" <cluster-devel@redhat.com>
> Sent: Friday, February 5, 2010 5:17:56 PM GMT -06:00 US/Canada Central
> Subject: [Cluster-devel] [GFS2 PATCH] - Bug 537201 - Better error reporting when mounting a gfs fs without enough
> journals
>
> Hi,
>
> We need this one-liner to signal the mount helper of the 'insufficient
> journals' condition.
>
> Signed-off-by: Abhijith Das <adas@redhat.com>
>
> diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c
> index d405c38..a054b52 100644
> --- a/fs/gfs2/ops_fstype.c
> +++ b/fs/gfs2/ops_fstype.c
> @@ -724,7 +724,7 @@ static int init_journal(struct gfs2_sbd *sdp, int
> undo)
> goto fail;
> }
>
> - error = -EINVAL;
> + error = -EUSERS;
> if (!gfs2_jindex_size(sdp)) {
> fs_err(sdp, "no journals!
");
> goto fail_jindex;
 
Old 02-08-2010, 09:57 AM
Steven Whitehouse
 
Default - Bug 537201 - Better error reporting when mounting a gfs fs without enough journals

Hi,

Now in the GFS2 -nmw git tree. Thanks,

Steve.

On Fri, 2010-02-05 at 18:25 -0500, Abhijith Das wrote:
> Please ignore the previous patch. The patch inlining didn't work right. Here's the unmangled one.
>
> --Abhi
>
> ----- "Abhijith Das" <adas@redhat.com> wrote:
>
> > From: "Abhijith Das" <adas@redhat.com>
> > To: "cluster-devel" <cluster-devel@redhat.com>
> > Sent: Friday, February 5, 2010 5:17:56 PM GMT -06:00 US/Canada Central
> > Subject: [Cluster-devel] [GFS2 PATCH] - Bug 537201 - Better error reporting when mounting a gfs fs without enough
> > journals
> >
> > Hi,
> >
> > We need this one-liner to signal the mount helper of the 'insufficient
> > journals' condition.
> >
> > Signed-off-by: Abhijith Das <adas@redhat.com>
> >
> > diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c
> > index d405c38..a054b52 100644
> > --- a/fs/gfs2/ops_fstype.c
> > +++ b/fs/gfs2/ops_fstype.c
> > @@ -724,7 +724,7 @@ static int init_journal(struct gfs2_sbd *sdp, int
> > undo)
> > goto fail;
> > }
> >
> > - error = -EINVAL;
> > + error = -EUSERS;
> > if (!gfs2_jindex_size(sdp)) {
> > fs_err(sdp, "no journals!
");
> > goto fail_jindex;
 

Thread Tools




All times are GMT. The time now is 05:54 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org