On Tue, 1 Dec 2009, Ingo Molnar wrote:
>
> Nice - thanks for doing this so quickly! It might sound like nitpicking
> but /proc ABIs tend to be a lot harder to get rid of than debugfs
> interfaces.

Ok, I applied it, so we'll not switch interfaces (even if they are just
for debugging) across releases.

Btw David, for things like this, it's _really_ nice to use git rename
detection. The diffstat (w/ summary) with rename detection looks like
this:

Documentation/slow-work.txt | 4 ++--
include/linux/slow-work.h | 8 ++++----
init/Kconfig | 8 ++++----
kernel/Makefile | 2 +-
kernel/{slow-work-proc.c => slow-work-debugfs.c} | 4 ++--
kernel/slow-work.c | 18 ++++++++++++------
kernel/slow-work.h | 6 +++---
7 files changed, 28 insertions(+), 22 deletions(-)
rename kernel/{slow-work-proc.c => slow-work-debugfs.c} (97%)

which makes it obvious that the changes were really just about renaming.
Compare to the non-rename-aware one:

Documentation/slow-work.txt | 4 +-
include/linux/slow-work.h | 8 +-
init/Kconfig | 8 +-
kernel/Makefile | 2 +-
kernel/slow-work-debugfs.c | 227 +++++++++++++++++++++++++++++++++++++++++++
kernel/slow-work-proc.c | 227 -------------------------------------------
kernel/slow-work.c | 18 +++-
kernel/slow-work.h | 6 +-
8 files changed, 253 insertions(+), 247 deletions(-)
create mode 100644 kernel/slow-work-debugfs.c
delete mode 100644 kernel/slow-work-proc.c

where you can kind of guess that slow-work-[proc|debugfs].c are largely
the same, but you don't actually _see_ that it only has four lines of
changes (and the patch then shows that the changes are just to comments).

Linus