FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > CentOS > CentOS

 
 
LinkBack Thread Tools
 
Old 04-28-2010, 07:15 PM
Hans de Goede
 
Default Don't clear BIOS RAID member disks (#586985)

With the new whole disk support code, we are now putting a fresh disklabel
on any BIOS RAID member disks (and multipath members) when
clearPartType is CLEARPART_TYPE_ALL. This is a rather serious bug, so
this patch should go to f13-branch and rhel6-branch as well.
---
storage/partitioning.py | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/storage/partitioning.py b/storage/partitioning.py
index c50dd0c..00c1986 100644
--- a/storage/partitioning.py
+++ b/storage/partitioning.py
@@ -310,6 +310,10 @@ def shouldClear(device, clearPartType, clearPartDisks=None):
if clearPartDisks and device.name not in clearPartDisks:
return False

+ # Never clear disks with hidden formats
+ if device.format.hidden:
+ return False
+
if clearPartType == CLEARPART_TYPE_LINUX and
not device.format.linuxNative:
return False
--
1.7.0.1

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 04-28-2010, 07:23 PM
David Lehman
 
Default Don't clear BIOS RAID member disks (#586985)

Ack.

On Wed, 2010-04-28 at 21:15 +0200, Hans de Goede wrote:
> With the new whole disk support code, we are now putting a fresh disklabel
> on any BIOS RAID member disks (and multipath members) when
> clearPartType is CLEARPART_TYPE_ALL. This is a rather serious bug, so
> this patch should go to f13-branch and rhel6-branch as well.
> ---
> storage/partitioning.py | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/storage/partitioning.py b/storage/partitioning.py
> index c50dd0c..00c1986 100644
> --- a/storage/partitioning.py
> +++ b/storage/partitioning.py
> @@ -310,6 +310,10 @@ def shouldClear(device, clearPartType, clearPartDisks=None):
> if clearPartDisks and device.name not in clearPartDisks:
> return False
>
> + # Never clear disks with hidden formats
> + if device.format.hidden:
> + return False
> +
> if clearPartType == CLEARPART_TYPE_LINUX and
> not device.format.linuxNative:
> return False


_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 

Thread Tools




All times are GMT. The time now is 07:21 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org