Linux Archive

Linux Archive (http://www.linux-archive.org/)
-   CentOS (http://www.linux-archive.org/centos/)
-   -   Don't select base packages and groups when going back. (http://www.linux-archive.org/centos/335256-dont-select-base-packages-groups-when-going-back.html)

Radek Vykydal 03-03-2010 03:29 PM

Don't select base packages and groups when going back.
 
We probably don't even need to do reset when going back, but I'd rather
stay on safer side here.

---
backend.py | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/backend.py b/backend.py
index 6ca14a8..4ec5e8c 100644
--- a/backend.py
+++ b/backend.py
@@ -303,9 +303,13 @@ def doInstall(anaconda):
def doBasePackageSelect(anaconda):
if anaconda.ksdata:
anaconda.backend.resetPackageSelections()
+ if anaconda.dir == DISPATCH_BACK:
+ return DISPATCH_BACK
kickstart.selectPackages(anaconda)
elif anaconda.displayMode != 't':
anaconda.backend.resetPackageSelections()
+ if anaconda.dir == DISPATCH_BACK:
+ return DISPATCH_BACK
anaconda.instClass.setPackageSelection(anaconda)
anaconda.instClass.setGroupSelection(anaconda)

--
1.6.0.6

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

Chris Lumens 03-03-2010 08:31 PM

Don't select base packages and groups when going back.
 
> diff --git a/backend.py b/backend.py
> index 6ca14a8..4ec5e8c 100644
> --- a/backend.py
> +++ b/backend.py
> @@ -303,9 +303,13 @@ def doInstall(anaconda):
> def doBasePackageSelect(anaconda):
> if anaconda.ksdata:
> anaconda.backend.resetPackageSelections()
> + if anaconda.dir == DISPATCH_BACK:
> + return DISPATCH_BACK
> kickstart.selectPackages(anaconda)
> elif anaconda.displayMode != 't':
> anaconda.backend.resetPackageSelections()
> + if anaconda.dir == DISPATCH_BACK:
> + return DISPATCH_BACK
> anaconda.instClass.setPackageSelection(anaconda)
> anaconda.instClass.setGroupSelection(anaconda)

Why do you want to reset but not select? This will have the effect that
if you make some package selections, go forward, and go back then your
previous selections will be forgotten. You won't even be set back to
the default - you'll just have nothing selected.

- Chris

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

Radek Vykydal 03-04-2010 07:06 AM

Don't select base packages and groups when going back.
 
Chris Lumens wrote:


Why do you want to reset but not select? This will have the effect that
if you make some package selections, go forward, and go back then your
previous selections will be forgotten. You won't even be set back to
the default - you'll just have nothing selected.



User package selection (group-selection step) happens just
*after* the step I am patching (basepkgsel), so the change
doesn't affect the flow from your case.

My point is that we don't need to select (*base packages*)
on our way back, we'll do it during the next way forward
(after eventual changes of repositories and task selection)
anyway.


Radek

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list


All times are GMT. The time now is 04:59 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.