FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > CentOS > CentOS

 
 
LinkBack Thread Tools
 
Old 03-11-2009, 11:24 AM
Radek Vykydal
 
Default Fix clamping of VG size in case when it is not sufficient for lvm metadata (#489549)

This fixes patch 6c6a206bd8dfc6910fc4061274bd4f054400c838 which
is essentialy kickstart part of a backport from rhel 5.3.
The original patch didn't take in account that PE size is
in KB, not MB. Also 1 PE per PV should be enough for lvm metadata.

I don't port gui part from 5.3 because the bug is for ks and
we are so close to release.
---
partRequests.py | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/partRequests.py b/partRequests.py
index f907525..fc89540 100644
--- a/partRequests.py
+++ b/partRequests.py
@@ -763,7 +763,7 @@ class VolumeGroupRequestSpec(RequestSpec):
#log("size for pv %s is %s" % (pvid, size))
clamped = lvm.clampPVSize(size, self.pesize)
if clamped == long(size):
- clamped = clamped - (2*self.pesize)
+ clamped = clamped - (self.pesize / 1024)
log(" got pv.size of %s, clamped to %s" % (size,clamped))
#log(" clamped size is %s" % (size,))
totalspace = totalspace + clamped
--
1.5.4.3

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 03-11-2009, 11:42 AM
Joel Granados
 
Default Fix clamping of VG size in case when it is not sufficient for lvm metadata (#489549)

looks ok.
On Wed, Mar 11, 2009 at 01:24:45PM +0100, Radek Vykydal wrote:
> This fixes patch 6c6a206bd8dfc6910fc4061274bd4f054400c838 which
> is essentialy kickstart part of a backport from rhel 5.3.
> The original patch didn't take in account that PE size is
> in KB, not MB. Also 1 PE per PV should be enough for lvm metadata.
>
> I don't port gui part from 5.3 because the bug is for ks and
> we are so close to release.
> ---
> partRequests.py | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/partRequests.py b/partRequests.py
> index f907525..fc89540 100644
> --- a/partRequests.py
> +++ b/partRequests.py
> @@ -763,7 +763,7 @@ class VolumeGroupRequestSpec(RequestSpec):
> #log("size for pv %s is %s" % (pvid, size))
> clamped = lvm.clampPVSize(size, self.pesize)
> if clamped == long(size):
> - clamped = clamped - (2*self.pesize)
> + clamped = clamped - (self.pesize / 1024)
> log(" got pv.size of %s, clamped to %s" % (size,clamped))
> #log(" clamped size is %s" % (size,))
> totalspace = totalspace + clamped
> --
> 1.5.4.3
>
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list@redhat.com
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list

--
Joel Andres Granados
Brno, Czech Republic, Red Hat.

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 

Thread Tools




All times are GMT. The time now is 08:26 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org