Sometimes, rpm returns the same kernel as being installed more than once due
to it having been in the transaction more than once (#467822). Let's make
sure that if that happens, we don't make the silliness continue
---
packages.py | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/packages.py b/packages.py
index 1e1214c..371e10e 100644
--- a/packages.py
+++ b/packages.py
@@ -298,6 +298,10 @@ def rpmKernelVersionList(rootPath = "/"):
if v == "" or tag == "":
log.warning("Unable to determine kernel type/version for %s-%s-%s.%s" %(h['name'], h['version'], h['release'], h['arch']))
continue
+ # rpm really shouldn't return the same kernel more than once... but
+ # sometimes it does (#467822)
+ if (v, h['arch'], tag) in versions:
+ continue
versions.append( (v, h['arch'], tag) )

return versions
--
1.6.0.3

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

> Sometimes, rpm returns the same kernel as being installed more than once due
> to it having been in the transaction more than once (#467822). Let's make
> sure that if that happens, we don't make the silliness continue
> ---
> packages.py | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/packages.py b/packages.py
> index 1e1214c..371e10e 100644
> --- a/packages.py
> +++ b/packages.py
> @@ -298,6 +298,10 @@ def rpmKernelVersionList(rootPath = "/"):
> if v == "" or tag == "":
> log.warning("Unable to determine kernel type/version for %s-%s-%s.%s" %(h['name'], h['version'], h['release'], h['arch']))
> continue
> + # rpm really shouldn't return the same kernel more than once... but
> + # sometimes it does (#467822)
> + if (v, h['arch'], tag) in versions:
> + continue
> versions.append( (v, h['arch'], tag) )
>
> return versions

Looks good to me. Is this why we sometime still end up seeing
"Installing kernel..." multiple times during an install? Or am I
imagining that?

- Chris

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

On Thu, 2008-11-06 at 14:12 -0500, Chris Lumens wrote:
> Looks good to me. Is this why we sometime still end up seeing
> "Installing kernel..." multiple times during an install? Or am I
> imagining that?
>

I've been seeing that myself, most notably when doing split media
testing as it's always the last thing "installed" from the first disk.

It's also led to the 'blah-base' duplicate grub entry.

--
Jesse Keating RHCE (http://jkeating.livejournal.com)
Fedora Project (http://fedoraproject.org/wiki/JesseKeating)
GPG Public Key (geek.j2solutions.net/jkeating.j2solutions.pub)
identi.ca (http://identi.ca/jkeating)
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list