On Fri, 2009-12-11 at 10:58 -0500, Chris Lumens wrote:
> > > Can you please post a link to the current state of your patch one more
> > > time? I might just commit it as-is. I'm not sure I really care about
> > > the install.img deleting thing.
> > >
> > > - Chris
> >
> > http://members.shaw.ca/jvonau/pub/F12/
> >
> > 0001-0005 are what I have working, 0006 is testing/work in progress.
>
> My one complaint remains with 0004 that I don't think freetmp is a
> YumBackend-specific method and should be put somewhere where all
> backends can make use of it. I wonder if it could be merged with
> backend.removeInstallImage.
>
I think that one is meant to delete the rhinstall-install.img from the
target system once the install is complete, think I'll leave that one as
is.

> Once this is addressed, I'm all for committing.

Thanks Chris, there is a 0004-revised.patch, (sorry, that one is not in
git format, please forgive me), and 0005-revised.patch at the above url.
Test running a vmm http install, working for me here.

Going to sleep now,

Jerry


_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

Hi,

On 12/16/2009 10:43 PM, Chris Lumens wrote:

Once this is addressed, I'm all for committing.


Thanks Chris, there is a 0004-revised.patch, (sorry, that one is not in
git format, please forgive me), and 0005-revised.patch at the above url.
Test running a vmm http install, working for me here.


Pushed, and will be rebuilding anaconda soon. Thanks for your patience
and revisions.



Chris,

Thanks for taking care of this, but something seems to have gone wrong
with this commit:
http://git.fedorahosted.org/git/?p=anaconda.git;a=commitdiff;h=98504bcaad593f3271a 76f1591120310c781049d

It removes the following line which it should not:
- free[-1][0])


And with this one:
http://git.fedorahosted.org/git/?p=anaconda.git;a=commitdiff;h=a75aa437f6fcbf98890 4b8a630cc82ef12c98dd6

The code for setting isodir and switching image now only happens under
the else block for the m.count(":") == 2 test, where as it should happens always
(as it did in the past).

I'll submit patches to fix this.

Regards,

Hans

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

> > Once this is addressed, I'm all for committing.
>
> Thanks Chris, there is a 0004-revised.patch, (sorry, that one is not in
> git format, please forgive me), and 0005-revised.patch at the above url.
> Test running a vmm http install, working for me here.

Pushed, and will be rebuilding anaconda soon. Thanks for your patience
and revisions.

- Chris

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list