FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > ArchLinux > ArchLinux User Repository

 
 
LinkBack Thread Tools
 
Old 01-13-2011, 03:46 PM
Sebastien Duthil
 
Default Package review : gPlanarity

Hi,

I'd like to submit this package to the AUR but, as it's my first
package, I'd like some reviews of the package before I send it.


Thanks !

Sebastien Duthil
 
Old 01-13-2011, 03:53 PM
Sebastien Duthil
 
Default Package review : gPlanarity

Le 13/01/2011 23:50, Lukas Fleischer a écrit :

Sooo...? Where is it?

Sorry, mailing list newbie too, I attached the file to the first mail :-[

Here it is :

http://dl.free.fr/poeSUbf0M
 
Old 01-13-2011, 03:54 PM
Sebastien Duthil
 
Default Package review : gPlanarity

Le 13/01/2011 17:53, Sebastien Duthil a écrit :

Here it is :

http://dl.free.fr/poeSUbf0M

Here is better

http://dl.free.fr/poeSUbf0M/gplanarity-16723-1.src.tar.gz

Sorry for the spam :-)
 
Old 01-13-2011, 04:45 PM
Sebastien Duthil
 
Default Package review : gPlanarity

Le 14/01/2011 00:02, Lukas Fleischer a écrit :


You don't need to include "cairo" and "freetype2" in the "depends" array
as they are already satisfied by gtk2 or it's deps but except for that,

Done. Thank you !

Le 14/01/2011 00:15, Dan Vratil a écrit :

Just being pedantic, but you should use "$srcdir" in case there were spaces in
the path.

Protected every variable. Thank you !

Package adopted and updated (only three clicks ... I really love
Archlinux ! I'll see about the CLI command next time).

https://aur.archlinux.org/packages.php?ID=16686

Thank you everyone !

Le 14/01/2011 00:09, Gordon JC Pearce a écrit :

Now, if you'll excuse me, I've got level five down to two
intersections...

And have fun :-)

Sebastien Duthil
 
Old 01-13-2011, 09:50 PM
Lukas Fleischer
 
Default Package review : gPlanarity

On Thu, Jan 13, 2011 at 05:46:43PM +0100, Sebastien Duthil wrote:
> I'd like to submit this package to the AUR but, as it's my first
> package, I'd like some reviews of the package before I send it.

Sooo...? Where is it?
 
Old 01-13-2011, 10:02 PM
Lukas Fleischer
 
Default Package review : gPlanarity

On Thu, Jan 13, 2011 at 05:53:08PM +0100, Sebastien Duthil wrote:
> http://dl.free.fr/poeSUbf0M

You don't need to include "cairo" and "freetype2" in the "depends" array
as they are already satisfied by gtk2 or it's deps but except for that,
it looks good to me
 
Old 01-13-2011, 10:09 PM
Gordon JC Pearce
 
Default Package review : gPlanarity

On Thu, 2011-01-13 at 17:54 +0100, Sebastien Duthil wrote:
> Le 13/01/2011 17:53, Sebastien Duthil a écrit :
> > Here it is :
> >
> > http://dl.free.fr/poeSUbf0M
> Here is better
>
> http://dl.free.fr/poeSUbf0M/gplanarity-16723-1.src.tar.gz
>
> Sorry for the spam :-)
>

Well, it builds, it doesn't send my computer into a screaming spiral of
despair and fail, and it's fun to play.

Good work ;-) Now, if you'll excuse me, I've got level five down to two
intersections...

Gordon MM0YEQ
 
Old 01-13-2011, 10:11 PM
Joel Heaton
 
Default Package review : gPlanarity

On Thu, 2011-01-13 at 17:54 +0100, Sebastien Duthil wrote:
> Le 13/01/2011 17:53, Sebastien Duthil a écrit :
> > Here it is :
> >
> > http://dl.free.fr/poeSUbf0M
> Here is better
>
> http://dl.free.fr/poeSUbf0M/gplanarity-16723-1.src.tar.gz
>
> Sorry for the spam :-)

Checked it over and it works just fine on my machine. Good work. :-)

Regards,

Joel.
 
Old 01-13-2011, 10:15 PM
Dan Vratil
 
Default Package review : gPlanarity

On Thursday, January 13, 2011 17:54:19 Sebastien Duthil wrote:
> Le 13/01/2011 17:53, Sebastien Duthil a écrit :
> > Here it is :
> >
> > http://dl.free.fr/poeSUbf0M
>
> Here is better
>
> http://dl.free.fr/poeSUbf0M/gplanarity-16723-1.src.tar.gz
>
> Sorry for the spam :-)

Just being pedantic, but you should use "$srcdir" in case there were spaces in
the path.

And thanks for bringing this in, it's really fun to play!

Dan

--
---
Dan Vrátil
vratil@progdansoft.com
Tel.: +420732326870
Jabber: progdan@jabber.cz

Tento email neobsahuje žádné viry, protože odesÃ*latel nepoužÃ*vá
Windows. / This email does not contain any viruses because the sender does not
use Windows.
 

Thread Tools




All times are GMT. The time now is 05:33 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright ©2007 - 2008, www.linux-archive.org