FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > ArchLinux > ArchLinux User Repository

 
 
LinkBack Thread Tools
 
Old 05-13-2010, 07:00 AM
Martin Sivak
 
Default Restructuralization of the sources and data in git repo

Hi,

I have prepared (with David's help) a set of patches that move files around and make the repository a bit cleaner and better organized. The biggest changes are moving anaconda files to pyanaconda/, binary stuff (isys, loader, gptsync) to bin/ and support files to data/.

The patched source builds manually (both make all and make dist) and in koji. I haven't tested compose.

I'm open to suggestions, but this structure helped me a lot during my investigation of unittesting approaches.

Martin

PS: Do not be fooled by moving isys around, first I thought the best placement for it should be as part of pyanaconda, but after make I quickly changed my mind.

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 05-13-2010, 07:05 AM
Martin Sivak
 
Default Restructuralization of the sources and data in git repo

If you want to see the repo without applying those huge patches, ping me on irc, I'll give you (RH internal sorry) url to my git.

--
Martin Sivák
msivak@redhat.com
Red Hat Czech
Anaconda team / Brno, CZ

----- "Martin Sivak" <msivak@redhat.com> wrote:

> Hi,
>
> I have prepared (with David's help) a set of patches that move files
> around and make the repository a bit cleaner and better organized. The
> biggest changes are moving anaconda files to pyanaconda/, binary stuff
> (isys, loader, gptsync) to bin/ and support files to data/.
>
> The patched source builds manually (both make all and make dist) and
> in koji. I haven't tested compose.
>
> I'm open to suggestions, but this structure helped me a lot during my
> investigation of unittesting approaches.
>
> Martin
>
> PS: Do not be fooled by moving isys around, first I thought the best
> placement for it should be as part of pyanaconda, but after make I
> quickly changed my mind.
>
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list@redhat.com
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 05-13-2010, 03:13 PM
Ales Kozumplik
 
Default Restructuralization of the sources and data in git repo

On 05/13/2010 09:00 AM, Martin Sivak wrote:

Hi,

I have prepared (with David's help) a set of patches that move files around and make the repository a bit cleaner and better organized. The biggest changes are moving anaconda files to pyanaconda/, binary stuff (isys, loader, gptsync) to bin/ and support files to data/.

The patched source builds manually (both make all and make dist) and in koji. I haven't tested compose.

I'm open to suggestions, but this structure helped me a lot during my investigation of unittesting approaches.

Martin

PS: Do not be fooled by moving isys around, first I thought the best placement for it should be as part of pyanaconda, but after make I quickly changed my mind.



Hi Martin,

I have some objections:
Why do you want to move things like loader/ or ui/ around? Those are
fine where they are right now, aren't they? Making the directory
structure deeper will just make us type more and work with the repo
slower. I suggest you only move the anaconda python files into
pyanaconda/ -- won't that be enough?


The first patch seems to remove and add anaconda to the root again.
Maybe it just appears weird because of the diff.


The second patch is called 'update build stuff' but it actually moves
files. Or am I reading it wrong?


In any case---with a change like this please make sure that the compose
passess and the images are bootable.


Ales

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 05-14-2010, 06:18 AM
Martin Sivak
 
Default Restructuralization of the sources and data in git repo

Hi,

I moved all data files to one subdirectory, which has the function of share directory in FHS terminology. The repository is much cleaner this way.

The second patch moves isys to another place, because my first intention was to make it part of pyanaconda package (it depends on pyutil). But during the build tests I figured out, that loader depends on it. Moving the files was the lesser evil in comparison to modifying all the loader sources (we use relative imports of isys header files). The dependency on iutil is then solved by PYTHONPATH in Makefiles and automake rules to move it to proper place after build.

Git format patch makes a monstrose changeset, because patch cannot handle file renames. It looks much better in git history.

--
Martin Sivák
msivak@redhat.com
Red Hat Czech
Anaconda team / Brno, CZ

----- "Ales Kozumplik" <akozumpl@redhat.com> wrote:

> On 05/13/2010 09:00 AM, Martin Sivak wrote:
> > Hi,
> >
> > I have prepared (with David's help) a set of patches that move files
> around and make the repository a bit cleaner and better organized. The
> biggest changes are moving anaconda files to pyanaconda/, binary stuff
> (isys, loader, gptsync) to bin/ and support files to data/.
> >
> > The patched source builds manually (both make all and make dist) and
> in koji. I haven't tested compose.
> >
> > I'm open to suggestions, but this structure helped me a lot during
> my investigation of unittesting approaches.
> >
> > Martin
> >
> > PS: Do not be fooled by moving isys around, first I thought the best
> placement for it should be as part of pyanaconda, but after make I
> quickly changed my mind.
> >
>
> Hi Martin,
>
> I have some objections:
> Why do you want to move things like loader/ or ui/ around? Those are
> fine where they are right now, aren't they? Making the directory
> structure deeper will just make us type more and work with the repo
> slower. I suggest you only move the anaconda python files into
> pyanaconda/ -- won't that be enough?
>
> The first patch seems to remove and add anaconda to the root again.
> Maybe it just appears weird because of the diff.
>
> The second patch is called 'update build stuff' but it actually moves
>
> files. Or am I reading it wrong?
>
> In any case---with a change like this please make sure that the
> compose
> passess and the images are bootable.
>
> Ales
>
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list@redhat.com
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 05-14-2010, 06:38 AM
Martin Sivak
 
Default Restructuralization of the sources and data in git repo

Also this is the result of rpmdiff between the new repo (master) and old repo (14.5) build:

msivak@euryale:~$ rpmdiff -i T -i S -i 5 tmp/anaconda-14.5-1.fc14.i686.rpm tmp/anaconda-14.5-1.fc14.i686.new.rpm
added /usr/lib/python2.6/site-packages/pyanaconda/isys
removed /usr/lib/python2.6/site-packages/pyanaconda/isys.py
removed /usr/lib/python2.6/site-packages/pyanaconda/isys.pyc
removed /usr/lib/python2.6/site-packages/pyanaconda/isys.pyo
added /usr/lib/python2.6/site-packages/pyanaconda/isys/__init__.py
added /usr/lib/python2.6/site-packages/pyanaconda/isys/__init__.pyc
added /usr/lib/python2.6/site-packages/pyanaconda/isys/__init__.pyo
removed /usr/lib/python2.6/site-packages/pyanaconda/run_test.py
removed /usr/lib/python2.6/site-packages/pyanaconda/run_test.pyc
removed /usr/lib/python2.6/site-packages/pyanaconda/run_test.pyo
added /usr/libexec/anaconda/auditd
added /usr/share/icons/hicolor/16x16
added /usr/share/icons/hicolor/16x16/apps
added /usr/share/icons/hicolor/16x16/apps/anaconda.png
added /usr/share/icons/hicolor/22x22
added /usr/share/icons/hicolor/22x22/apps
added /usr/share/icons/hicolor/22x22/apps/anaconda.png
added /usr/share/icons/hicolor/24x24
added /usr/share/icons/hicolor/24x24/apps
added /usr/share/icons/hicolor/24x24/apps/anaconda.png
added /usr/share/icons/hicolor/32x32
added /usr/share/icons/hicolor/32x32/apps
added /usr/share/icons/hicolor/32x32/apps/anaconda.png
added /usr/share/icons/hicolor/48x48
added /usr/share/icons/hicolor/48x48/apps
added /usr/share/icons/hicolor/48x48/apps/anaconda.png

--
Martin Sivák
msivak@redhat.com
Red Hat Czech
Anaconda team / Brno, CZ

----- "Ales Kozumplik" <akozumpl@redhat.com> wrote:

> On 05/13/2010 09:00 AM, Martin Sivak wrote:
> > Hi,
> >
> > I have prepared (with David's help) a set of patches that move files
> around and make the repository a bit cleaner and better organized. The
> biggest changes are moving anaconda files to pyanaconda/, binary stuff
> (isys, loader, gptsync) to bin/ and support files to data/.
> >
> > The patched source builds manually (both make all and make dist) and
> in koji. I haven't tested compose.
> >
> > I'm open to suggestions, but this structure helped me a lot during
> my investigation of unittesting approaches.
> >
> > Martin
> >
> > PS: Do not be fooled by moving isys around, first I thought the best
> placement for it should be as part of pyanaconda, but after make I
> quickly changed my mind.
> >
>
> Hi Martin,
>
> I have some objections:
> Why do you want to move things like loader/ or ui/ around? Those are
> fine where they are right now, aren't they? Making the directory
> structure deeper will just make us type more and work with the repo
> slower. I suggest you only move the anaconda python files into
> pyanaconda/ -- won't that be enough?
>
> The first patch seems to remove and add anaconda to the root again.
> Maybe it just appears weird because of the diff.
>
> The second patch is called 'update build stuff' but it actually moves
>
> files. Or am I reading it wrong?
>
> In any case---with a change like this please make sure that the
> compose
> passess and the images are bootable.
>
> Ales
>
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list@redhat.com
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 05-14-2010, 07:00 AM
Ales Kozumplik
 
Default Restructuralization of the sources and data in git repo

On 05/14/2010 08:18 AM, Martin Sivak wrote:

Hi,

I moved all data files to one subdirectory, which has the function of share directory in FHS terminology. The repository is much cleaner this way.

The second patch moves isys to another place, because my first intention was to make it part of pyanaconda package (it depends on pyutil). But during the build tests I figured out, that loader depends on it. Moving the files was the lesser evil in comparison to modifying all the loader sources (we use relative imports of isys header files). The dependency on iutil is then solved by PYTHONPATH in Makefiles and automake rules to move it to proper place after build.

Git format patch makes a monstrose changeset, because patch cannot handle file renames. It looks much better in git history.

--


Yes,

I looked at the repo layout now and I like it a lot. Ack from me, but
someone else who was more in love with the old layout ACKs that too.


Ales

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 05-14-2010, 07:26 AM
Jesse Keating
 
Default Restructuralization of the sources and data in git repo

On Fri, 2010-05-14 at 02:18 -0400, Martin Sivak wrote:
>
> Git format patch makes a monstrose changeset, because patch cannot
> handle file renames. It looks much better in git history.
>
>

Try using the -M option to format-patch. It's a much more sane looking
output, and still usable by git am.

--
Jesse Keating
Fedora -- Freedom˛ is a feature!
identi.ca: http://identi.ca/jkeating
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 05-14-2010, 08:35 PM
Chris Lumens
 
Default Restructuralization of the sources and data in git repo

> If you want to see the repo without applying those huge patches, ping me on irc, I'll give you (RH internal sorry) url to my git.

If you could just dump the output of ls -R into a mail on this thread,
it would be great. Reading through these kinds of patches (and I'm
certainly guilty of similar major structural changes) is always
impossible.

- Chris

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 05-14-2010, 08:37 PM
Chris Lumens
 
Default Restructuralization of the sources and data in git repo

> I moved all data files to one subdirectory, which has the function of
> share directory in FHS terminology. The repository is much cleaner
> this way.

I do like the direction this is moving in, though I'm not sure I see
much value in moving ui/ and loader/ either. Those are pretty well
contained specialized directories. It's not a grab bag of crap like the
top-level currently is.

Does moving them help with test case writing or code simplification in
some way?

- Chris

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 05-17-2010, 10:18 AM
Martin Sivak
 
Default Restructuralization of the sources and data in git repo

Actually, no..

moving loader and ui was just a cleanup to put all binary (arch specific) stuff in one place and arch independent (icons, glade files..) to another. I just considered ui/ to be in the same category as fonts, icons, ....

If I put loader/ back in root, I have to do the same for isys/ or change all loader source files.

--
Martin Sivák
msivak@redhat.com
Red Hat Czech
Anaconda team / Brno, CZ

----- "Chris Lumens" <clumens@redhat.com> wrote:

> > I moved all data files to one subdirectory, which has the function
> of
> > share directory in FHS terminology. The repository is much cleaner
> > this way.
>
> I do like the direction this is moving in, though I'm not sure I see
> much value in moving ui/ and loader/ either. Those are pretty well
> contained specialized directories. It's not a grab bag of crap like
> the
> top-level currently is.
>
> Does moving them help with test case writing or code simplification
> in
> some way?
>
> - Chris
>
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list@redhat.com
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 

Thread Tools




All times are GMT. The time now is 07:13 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright ©2007 - 2008, www.linux-archive.org