diff --git a/iw/lvm_dialog_gui.py b/iw/lvm_dialog_gui.py
index ec043de..cffb68c 100644
--- a/iw/lvm_dialog_gui.py
+++ b/iw/lvm_dialog_gui.py
@@ -707,13 +707,14 @@ class VolumeGroupEditor:
templv.size = size
except ValueError:
self.intf.messageWindow(_("Not enough space"),
- _("The logical volumes you have "
- "configured require %(size)d MB,"
- " but the volume group only has "
- "%(tempvgsize)d MB. Please "
- "either make the volume group "
- "larger or make the logical "
- "volume(s) smaller.")
+ _("The size entered for this "
+ "logical volume (%(size)d MB) "
+ "exceeds the available space "
+ "of the volume group "
+ "(%(tempvgsize)d MB). Please "
+ "make the volume group larger "
+ "or make the logical volume "
+ "smaller.")
% {'size': size,
'tempvgsize': tempvg.size},
custom_icon="error")
--
1.6.6.1
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
05-03-2010, 08:49 AM
Hans de Goede
Clean up wording for oversized LVs (#587459)
Hi,
The new message suggests / could be read as the VG still having
tempvg.size free, but AFAIK tempvg.size is the VG size,
not the free space in the VG.
diff --git a/iw/lvm_dialog_gui.py b/iw/lvm_dialog_gui.py
index ec043de..cffb68c 100644
--- a/iw/lvm_dialog_gui.py
+++ b/iw/lvm_dialog_gui.py
@@ -707,13 +707,14 @@ class VolumeGroupEditor:
templv.size = size
except ValueError:
self.intf.messageWindow(_("Not enough space"),
- _("The logical volumes you have "
- "configured require %(size)d MB,"
- " but the volume group only has "
- "%(tempvgsize)d MB. Please "
- "either make the volume group "
- "larger or make the logical "
- "volume(s) smaller.")
+ _("The size entered for this "
+ "logical volume (%(size)d MB) "
+ "exceeds the available space "
+ "of the volume group "
+ "(%(tempvgsize)d MB). Please "
+ "make the volume group larger "
+ "or make the logical volume "
+ "smaller.")
% {'size': size,
'tempvgsize': tempvg.size},
custom_icon="error")
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
diff --git a/iw/lvm_dialog_gui.py b/iw/lvm_dialog_gui.py
index ec043de..7d1a262 100644
--- a/iw/lvm_dialog_gui.py
+++ b/iw/lvm_dialog_gui.py
@@ -707,13 +707,15 @@ class VolumeGroupEditor:
templv.size = size
except ValueError:
self.intf.messageWindow(_("Not enough space"),
- _("The logical volumes you have "
- "configured require %(size)d MB,"
- " but the volume group only has "
- "%(tempvgsize)d MB. Please "
- "either make the volume group "
- "larger or make the logical "
- "volume(s) smaller.")
+ _("The size entered for this "
+ "logical volume (%(size)d MB) "
+ "combined with the size of the "
+ "other logical volume(s) "
+ "exceeds the size of the "
+ "volume group (%(tempvgsize)d "
+ "MB). Please make the volume "
+ "group larger or make the "
+ "logical volume smaller.")
% {'size': size,
'tempvgsize': tempvg.size},
custom_icon="error")
--
1.6.6.1
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
05-04-2010, 05:33 AM
David Cantrell
Clean up wording for oversized LVs (#587459)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On Mon, 3 May 2010, Hans de Goede wrote:
The new message suggests / could be read as the VG still having
tempvg.size free, but AFAIK tempvg.size is the VG size,
not the free space in the VG.
Good point. I reworded it a bit and sent the updated patch as part of the
four patch series I posted today. However, I'm not really sure the rewording
clears up the confusion for users any less.
diff --git a/iw/lvm_dialog_gui.py b/iw/lvm_dialog_gui.py
index ec043de..cffb68c 100644
--- a/iw/lvm_dialog_gui.py
+++ b/iw/lvm_dialog_gui.py
@@ -707,13 +707,14 @@ class VolumeGroupEditor:
templv.size = size
except ValueError:
self.intf.messageWindow(_("Not enough space"),
- _("The logical volumes you
have "
- "configured require %(size)d
MB,"
- " but the volume group only
has "
- "%(tempvgsize)d MB. Please
"
- "either make the volume
group "
- "larger or make the logical
"
- "volume(s) smaller.")
+ _("The size entered for this "
+ "logical volume (%(size)d
MB) "
+ "exceeds the available space
"
+ "of the volume group "
+ "(%(tempvgsize)d MB). Please
"
+ "make the volume group
larger "
+ "or make the logical volume
"
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
05-04-2010, 07:53 AM
Hans de Goede
Clean up wording for oversized LVs (#587459)
Hi,
Better, but not really pretty. It would be better IMHO to just figure
out with some calculation how much free space is still available and
show that in the error dialog (don't we already calculate this somewhere?).
Anyways, I would prefer a better dialog, but if that turns out to be
hard to do, ACK.
diff --git a/iw/lvm_dialog_gui.py b/iw/lvm_dialog_gui.py
index ec043de..7d1a262 100644
--- a/iw/lvm_dialog_gui.py
+++ b/iw/lvm_dialog_gui.py
@@ -707,13 +707,15 @@ class VolumeGroupEditor:
templv.size = size
except ValueError:
self.intf.messageWindow(_("Not enough space"),
- _("The logical volumes you have "
- "configured require %(size)d MB,"
- " but the volume group only has "
- "%(tempvgsize)d MB. Please "
- "either make the volume group "
- "larger or make the logical "
- "volume(s) smaller.")
+ _("The size entered for this "
+ "logical volume (%(size)d MB) "
+ "combined with the size of the "
+ "other logical volume(s) "
+ "exceeds the size of the "
+ "volume group (%(tempvgsize)d "
+ "MB). Please make the volume "
+ "group larger or make the "
+ "logical volume smaller.")
% {'size': size,
'tempvgsize': tempvg.size},
custom_icon="error")
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
Clean up wording for oversized LVs (#587459)
