Community commit messages

On Fri, Nov 06, 2009 at 08:32:31PM +0100, Chris Brannon wrote:
> Ionut Biru wrote:
> > the default message is "updpkg: $pkname $pkgver"
>
> communitypkg doesn't prompt for a message. I stopped using it during
> the cvs -> svn transition, because I didn't have a version that used
> svn. The nice thing about calling svn commit directly is that it prompts
> you for a commit message, and even spawns an editor so you can write it.
> There is no "default".
> Yay for doing things by hand!
>
> -- Chris
>

I think communitypkg pops up a window on my machine asking for commit
message. I was using it, but just with the short cryptic messages Loui
mentioned. I promise I will change this

Cheers
Jaroslav

--
"Plan to throw one away. You will anyway."
- Fred Brooks, "The Mythical Man Month"

On Fri, Nov 6, 2009 at 6:46 PM, Loui Chang <louipc.ist@gmail.com> wrote:
> Hey TUs,
> Please make descriptive commit messages when committing changes
> to SVN. I've seen a lack of messages, or cryptic ones like 'FS#1234'.
> Please describe the change, or the issue it's solving in plain language.
>
> Thanks.

Maybe it's worth to express it in the documentation/wiki if it's not
described at this momment, if you feel it useful.

On Fri 06 Nov 2009 14:02 -0500, Daenyth Blank wrote:
> On Fri, Nov 6, 2009 at 13:36, Loui Chang <louipc.ist@gmail.com> wrote:
> > Commit messages should explain the commit, clarify reasons for it and
> > not fully rely on outside reference.

> At least for most of my updates, it's nothing more than pkgver/md5
> changes. Do I really need to elaborate beyond the summary line?

Yeah I'd say for package upgrades that should be enough. When there are
bug fixes or other changes a more descriptive commit message would be
appreciated.

Chris Brannon wrote:
> Ionut Biru wrote:
> > the default message is "updpkg: $pkname $pkgver"
>
> communitypkg doesn't prompt for a message. I stopped using it during
> the cvs -> svn transition, because I didn't have a version that used
> svn. The nice thing about calling svn commit directly is that it prompts
> you for a commit message, and even spawns an editor so you can write it.
> There is no "default".
> Yay for doing things by hand!
>
> -- Chris

I've been using my own scripts to handle build->upload->commit. I'll
tweak those to prompt for commit messages instead of appending whatever
default message I've been using.

Xyne wrote:

Chris Brannon wrote:

Ionut Biru wrote:

the default message is "updpkg: $pkname $pkgver"

communitypkg doesn't prompt for a message. I stopped using it during
the cvs -> svn transition, because I didn't have a version that used
svn. The nice thing about calling svn commit directly is that it prompts
you for a commit message, and even spawns an editor so you can write it.
There is no "default".
Yay for doing things by hand!

-- Chris


I've been using my own scripts to handle build->upload->commit. I'll
tweak those to prompt for commit messages instead of appending whatever
default message I've been using.



Why? What is wrong with the scripts in devtools? It is just
'makechrootpkg' followed by 'communitypkg "message"'.



You are lucky Aaron is on holiday because people not using those scripts
is one of his pet peeves.

Alan McRae wrote:
> Xyne wrote:
> > I've been using my own scripts to handle build->upload->commit. I'll
> > tweak those to prompt for commit messages instead of appending whatever
> > default message I've been using.
> >
>
> You are lucky Aaron is on holiday because people not using those scripts
> is one of his pet peeves.

Hrm. Looks like I have a retraction / apology to make!
The default message went away from communitypkg months ago. Just checked.

I'm going to go back to using the scripts; wouldn't want to
be a target in anyone's crosshairs *grin*!

-- Chris

> Why? What is wrong with the scripts in devtools? It is just
> 'makechrootpkg' followed by 'communitypkg "message"'.
>
>
> You are lucky Aaron is on holiday because people not using those scripts
> is one of his pet peeves.
>

I wrote my own during the transition before the old ones were updated
to handle SVN. They plug into the system which I use to update the
projects on my site and they work as expected. There's no reason not to
use them right now.

Now stop bumping this so it can get buried before
I have to dodge falling cars. :P