FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > ArchLinux > ArchLinux User Repository

 
 
LinkBack Thread Tools
 
Old 03-24-2009, 08:44 AM
Joel Granados Moreno
 
Default Don't remove partitions twice.

We remove the partitions at the end of clearpart function when we
traverse the clearpart list and "Destroy" each partition.
---
storage/partitioning.py | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/storage/partitioning.py b/storage/partitioning.py
index fdaf360..95d6ec2 100644
--- a/storage/partitioning.py
+++ b/storage/partitioning.py
@@ -318,9 +318,6 @@ def clearPartitions(storage):
storage.destroyDevice(leaf)
devices.remove(leaf)

- # FIXME: this should be taken care of by DeviceTree.removeDevice
- # or Storage.destroyDevice
- part.partedPartition.disk.removePartition(part.par tedPartition)
log.debug("partitions: %s" % [p.getDeviceNodeName() for p in part.partedPartition.disk.partitions])
disk_name = os.path.basename(part.partedPartition.disk.device. path)
if disk_name not in disks:
--
1.6.0.6

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 03-24-2009, 08:48 AM
Hans de Goede
 
Default Don't remove partitions twice.

On 03/24/2009 10:44 AM, Joel Granados Moreno wrote:

We remove the partitions at the end of clearpart function when we
traverse the clearpart list and "Destroy" each partition.


Looks good,

Regards,

Hans


---
storage/partitioning.py | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/storage/partitioning.py b/storage/partitioning.py
index fdaf360..95d6ec2 100644
--- a/storage/partitioning.py
+++ b/storage/partitioning.py
@@ -318,9 +318,6 @@ def clearPartitions(storage):
storage.destroyDevice(leaf)
devices.remove(leaf)

- # FIXME: this should be taken care of by DeviceTree.removeDevice
- # or Storage.destroyDevice
- part.partedPartition.disk.removePartition(part.par tedPartition)
log.debug("partitions: %s" % [p.getDeviceNodeName() for p in part.partedPartition.disk.partitions])
disk_name = os.path.basename(part.partedPartition.disk.device. path)
if disk_name not in disks:


_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 

Thread Tools




All times are GMT. The time now is 12:56 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org