FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > ArchLinux > ArchLinux Pacman Development

 
 
LinkBack Thread Tools
 
Old 05-26-2008, 06:27 AM
Allan McRae
 
Default Tidy up of the handle struct in libalpm

Removed unused handle->uid from pmhandle_t. The need to check permissions
should be determined by the frontend (and is in pacman).

Fixed comment on noextract in pmhandle_t.

Signed-off-by: Allan McRae <mcrae_allan@hotmail.com>
---
lib/libalpm/handle.c | 3 ---
lib/libalpm/handle.h | 3 +--
2 files changed, 1 insertions(+), 5 deletions(-)

diff --git a/lib/libalpm/handle.c b/lib/libalpm/handle.c
index 5f209d4..c01dd55 100644
--- a/lib/libalpm/handle.c
+++ b/lib/libalpm/handle.c
@@ -23,7 +23,6 @@

#include <stdlib.h>
#include <string.h>
-#include <unistd.h>
#include <limits.h>
#include <sys/types.h>
#include <syslog.h>
@@ -53,8 +52,6 @@ pmhandle_t *_alpm_handle_new()
handle->lckfd = -1;
handle->logstream = NULL;

- /* see if we're root or not */
- handle->uid = geteuid();
handle->root = NULL;
handle->dbpath = NULL;
handle->cachedirs = NULL;
diff --git a/lib/libalpm/handle.h b/lib/libalpm/handle.h
index 5051917..9c537b1 100644
--- a/lib/libalpm/handle.h
+++ b/lib/libalpm/handle.h
@@ -30,7 +30,6 @@

typedef struct _pmhandle_t {
/* internal usage */
- uid_t uid; /* current UID */ /* TODO is this used? */
pmdb_t *db_local; /* local db pointer */
alpm_list_t *dbs_sync; /* List of (pmdb_t *) */
FILE *logstream; /* log file stream pointer */
@@ -50,7 +49,7 @@ typedef struct _pmhandle_t {

/* package lists */
alpm_list_t *noupgrade; /* List of packages NOT to be upgraded */
- alpm_list_t *noextract; /* List of packages NOT to extract */ /*TODO is this used?*/
+ alpm_list_t *noextract; /* List of files NOT to extract */
alpm_list_t *ignorepkg; /* List of packages to ignore */
alpm_list_t *holdpkg; /* List of packages which 'hold' pacman */
alpm_list_t *ignoregrp; /* List of groups to ignore */
--
1.5.5.1


_______________________________________________
pacman-dev mailing list
pacman-dev@archlinux.org
http://archlinux.org/mailman/listinfo/pacman-dev
 
Old 05-26-2008, 08:46 AM
Xavier
 
Default Tidy up of the handle struct in libalpm

On Mon, May 26, 2008 at 8:27 AM, Allan McRae <mcrae_allan@hotmail.com> wrote:
> Removed unused handle->uid from pmhandle_t. The need to check permissions
> should be determined by the frontend (and is in pacman).
>
> Fixed comment on noextract in pmhandle_t.
>
> Signed-off-by: Allan McRae <mcrae_allan@hotmail.com>

Ok good

_______________________________________________
pacman-dev mailing list
pacman-dev@archlinux.org
http://archlinux.org/mailman/listinfo/pacman-dev
 
Old 05-27-2008, 11:05 AM
"Dan McGee"
 
Default Tidy up of the handle struct in libalpm

On Mon, May 26, 2008 at 3:46 AM, Xavier <shiningxc@gmail.com> wrote:
> On Mon, May 26, 2008 at 8:27 AM, Allan McRae <mcrae_allan@hotmail.com> wrote:
>> Removed unused handle->uid from pmhandle_t. The need to check permissions
>> should be determined by the frontend (and is in pacman).
>>
>> Fixed comment on noextract in pmhandle_t.
>>
>> Signed-off-by: Allan McRae <mcrae_allan@hotmail.com>
>
> Ok good

Looks OK here.

-Dan

_______________________________________________
pacman-dev mailing list
pacman-dev@archlinux.org
http://archlinux.org/mailman/listinfo/pacman-dev
 

Thread Tools




All times are GMT. The time now is 06:08 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org