FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > ArchLinux > ArchLinux Pacman Development

 
 
LinkBack Thread Tools
 
Old 05-10-2008, 04:31 PM
Allan McRae
 
Default Tidy up missing changelog error message

Removes a small TODO from the codebase

Signed-off-by: Allan McRae <mcrae_allan@hotmail.com>
---
src/pacman/package.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/src/pacman/package.c b/src/pacman/package.c
index 76e8e4f..6f4a195 100644
--- a/src/pacman/package.c
+++ b/src/pacman/package.c
@@ -245,8 +245,7 @@ void dump_pkg_changelog(pmpkg_t *pkg)
void *fp = NULL;

if((fp = alpm_pkg_changelog_open(pkg)) == NULL) {
- /* TODO after string freeze use pm_fprintf */
- fprintf(stderr, _("error: no changelog available for '%s'.
"),
+ pm_fprintf(stderr, PM_LOG_ERROR, "no changelog available for '%s'.
",
alpm_pkg_get_name(pkg));
return;
} else {
--
1.5.5.1


_______________________________________________
pacman-dev mailing list
pacman-dev@archlinux.org
http://archlinux.org/mailman/listinfo/pacman-dev
 
Old 05-10-2008, 04:39 PM
"Dan McGee"
 
Default Tidy up missing changelog error message

On Sat, May 10, 2008 at 11:31 AM, Allan McRae <mcrae_allan@hotmail.com> wrote:
> Removes a small TODO from the codebase
>
> Signed-off-by: Allan McRae <mcrae_allan@hotmail.com>
> ---
> src/pacman/package.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/src/pacman/package.c b/src/pacman/package.c
> index 76e8e4f..6f4a195 100644
> --- a/src/pacman/package.c
> +++ b/src/pacman/package.c
> @@ -245,8 +245,7 @@ void dump_pkg_changelog(pmpkg_t *pkg)
> void *fp = NULL;
>
> if((fp = alpm_pkg_changelog_open(pkg)) == NULL) {
> - /* TODO after string freeze use pm_fprintf */
> - fprintf(stderr, _("error: no changelog available for '%s'.
"),
> + pm_fprintf(stderr, PM_LOG_ERROR, "no changelog available for '%s'.
",
Ooo, nice.

Any chance you want to fold this into a bigger patch, hopefully
slightly tested, finding more of these types of things? This one
wasn't alone.

$ grep 'fprintf.*error' * | wc -l
41

Of course, this gives me second thoughts- we are using a libalpm
defined logging constant in our front end application. should we be
doing this?

> alpm_pkg_get_name(pkg));
> return;
> } else {
> --
> 1.5.5.1
>
>
> _______________________________________________
> pacman-dev mailing list
> pacman-dev@archlinux.org
> http://archlinux.org/mailman/listinfo/pacman-dev
>

_______________________________________________
pacman-dev mailing list
pacman-dev@archlinux.org
http://archlinux.org/mailman/listinfo/pacman-dev
 
Old 05-10-2008, 05:12 PM
Allan McRae
 
Default Tidy up missing changelog error message

Dan McGee wrote:
> On Sat, May 10, 2008 at 11:31 AM, Allan McRae <mcrae_allan@hotmail.com> wrote:
>> if((fp = alpm_pkg_changelog_open(pkg)) == NULL) {
>> - /* TODO after string freeze use pm_fprintf */
>> - fprintf(stderr, _("error: no changelog available for '%s'.
"),
>> + pm_fprintf(stderr, PM_LOG_ERROR, "no changelog available for '%s'.
",
>>
> Ooo, nice.
>
> Any chance you want to fold this into a bigger patch, hopefully
> slightly tested, finding more of these types of things? This one
> wasn't alone.
>
> $ grep 'fprintf.*error' * | wc -l
> 41
>
>

Sure, I was just picking out some small things to tidy up but they
always turn out to be bigger that you expected!

> Of course, this gives me second thoughts- we are using a libalpm
> defined logging constant in our front end application. should we be
> doing this?
>

Hmm.... It is a publicly available define so I guess it is alright.
Alternatively, we essentially duplicate the define for use in the
frontend. which seems wasteful.





_______________________________________________
pacman-dev mailing list
pacman-dev@archlinux.org
http://archlinux.org/mailman/listinfo/pacman-dev
 

Thread Tools




All times are GMT. The time now is 05:03 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org