Linux Archive

Linux Archive (http://www.linux-archive.org/)
-   ArchLinux Pacman Development (http://www.linux-archive.org/archlinux-pacman-development/)
-   -   query: avoid false ownership matches for files in root (http://www.linux-archive.org/archlinux-pacman-development/675199-query-avoid-false-ownership-matches-files-root.html)

Allan McRae 06-20-2012 10:55 PM

query: avoid false ownership matches for files in root
 
On 21/06/12 06:23, Dave Reisner wrote:
> Check for an exact match when querying ownership of files in the root.
> Previously, our test was too simple and would match the the basename of
> package files against the query parameter, e.g.
>
> $ pacman -Qo config
> /config is owned by cower-git 20120614-1
>
> Adds a new test to verify this behavior, query007.py.
>
> Fixes FS#30388.
>
> Signed-off-by: Dave Reisner <dreisner@archlinux.org>
> ---


I can not replicate this issue so it was likely already fixed by my "-Qo
<dir>" patch. I seem to remember encountering something like that...
It would be really good if someone could review the patches that Andrew
and I sent to this list for that...

Anyway, the pactest looks good.

Allan

Dave Reisner 06-21-2012 12:06 AM

query: avoid false ownership matches for files in root
 
On Thu, Jun 21, 2012 at 08:55:44AM +1000, Allan McRae wrote:
> On 21/06/12 06:23, Dave Reisner wrote:
> > Check for an exact match when querying ownership of files in the root.
> > Previously, our test was too simple and would match the the basename of
> > package files against the query parameter, e.g.
> >
> > $ pacman -Qo config
> > /config is owned by cower-git 20120614-1
> >
> > Adds a new test to verify this behavior, query007.py.
> >
> > Fixes FS#30388.
> >
> > Signed-off-by: Dave Reisner <dreisner@archlinux.org>
> > ---
>
>
> I can not replicate this issue so it was likely already fixed by my "-Qo
> <dir>" patch. I seem to remember encountering something like that...
> It would be really good if someone could review the patches that Andrew
> and I sent to this list for that...
>
> Anyway, the pactest looks good.
>
> Allan
>

Ah, if that's the case then I'll just drop the fix and add the test as
expectedfail.


All times are GMT. The time now is 04:35 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.