FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > ArchLinux > ArchLinux Pacman Development

 
 
LinkBack Thread Tools
 
Old 06-20-2012, 03:28 AM
Allan McRae
 
Default makepkg: fix log file names for arch=any packages

On 20/06/12 07:56, Florian Pritz wrote:
> Signed-off-by: Florian Pritz <bluewind@xinu.at>
> ---
> scripts/makepkg.sh.in | 21 ++++++++++++++++-----
> 1 file changed, 16 insertions(+), 5 deletions(-)
>


Mentioned on IRC, but posting here to be on record. This does not
handle split packages that have different architectures.

Allan
 
Old 06-20-2012, 02:31 PM
Florian Pritz
 
Default makepkg: fix log file names for arch=any packages

On 06/20/2012 05:28 AM, Allan McRae wrote:
> This does not
> handle split packages that have different architectures.

Split packages use pkgbase rather than pkgname[@] as the name for the
logfile, so even if you override arch from within a package function my
patch should work.

Could someone else take a look?

--
Florian Pritz -- {flo,bluewind}@server-speed.net
 
Old 06-20-2012, 02:56 PM
Allan McRae
 
Default makepkg: fix log file names for arch=any packages

On 21/06/12 00:31, Florian Pritz wrote:
> On 06/20/2012 05:28 AM, Allan McRae wrote:
>> This does not
>> handle split packages that have different architectures.
>
> Split packages use pkgbase rather than pkgname[@] as the name for the
> logfile, so even if you override arch from within a package function my
> patch should work.
>
> Could someone else take a look?
>


On 21/06/12 00:31, Florian Pritz wrote:> On 06/20/2012 05:28 AM, Allan
McRae wrote:
>> This does not
>> handle split packages that have different architectures.
>
> Split packages use pkgbase rather than pkgname[@] as the name for the
> logfile, so even if you override arch from within a package function my
> patch should work.
>
> Could someone else take a look?
>


What should the log file names be for this PKGBUILD?

pkgname=('foo' 'bar')
pkgver=1
pkgrel=1
arch=('i686' 'x86_64')

package_foo() {
:
}

package_bar() {
arch=('any')
}


What about for this one?

pkgname=('foo' 'bar')
pkgver=1
pkgrel=1
arch=('any')

package_foo() {
:
}

package_bar() {
arch=('i686' 'x86_64')
}



Now... I actually like the actual build arch listed in the log file
name. If I have an "arch=any" package that fails only on a certain
architecture, it is handy to know what arch it was build on. So I see
the current behaviour as a feature and not a bug.

Allan
 

Thread Tools




All times are GMT. The time now is 11:16 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org