Linux Archive

Linux Archive (http://www.linux-archive.org/)
-   ArchLinux Pacman Development (http://www.linux-archive.org/archlinux-pacman-development/)
-   -   pacman-key: hanlde local signing of multiple keys (http://www.linux-archive.org/archlinux-pacman-development/674468-pacman-key-hanlde-local-signing-multiple-keys.html)

Pierre Schmitz 06-19-2012 12:31 PM

pacman-key: hanlde local signing of multiple keys
 
Am 19.06.2012 06:56, schrieb Allan McRae:
> gpg --lsign-key does not like being given multiple keys to sign.
>
> Signed-off-by: Allan McRae <allan@archlinux.org>
> ---
> scripts/pacman-key.sh.in | 18 +++++++++++++-----
> 1 file changed, 13 insertions(+), 5 deletions(-)
>
> diff --git a/scripts/pacman-key.sh.in b/scripts/pacman-key.sh.in
> index e5b6021..d2389b0 100644
> --- a/scripts/pacman-key.sh.in
> +++ b/scripts/pacman-key.sh.in
> @@ -301,7 +301,6 @@ populate_keyring() {
> if (( ${#trusted_ids[@]} > 0 )); then
> msg "$(gettext "Locally signing trusted keys in keyring...")"
> for key_id in "${!trusted_ids[@]}"; do
> - msg2 "$(gettext "Locally signing key %s...")" "${key_id}"
> lsign_keys "${key_id}"
> done

I'd suggest to replace the entire for loop with this then:

lsign_keys "${!trusted_ids[@]}"

--
Pierre Schmitz, https://pierre-schmitz.com

Allan McRae 06-20-2012 03:25 AM

pacman-key: hanlde local signing of multiple keys
 
On 19/06/12 22:31, Pierre Schmitz wrote:
> Am 19.06.2012 06:56, schrieb Allan McRae:
>> gpg --lsign-key does not like being given multiple keys to sign.
>>
>> Signed-off-by: Allan McRae <allan@archlinux.org>
>> ---
>> scripts/pacman-key.sh.in | 18 +++++++++++++-----
>> 1 file changed, 13 insertions(+), 5 deletions(-)
>>
>> diff --git a/scripts/pacman-key.sh.in b/scripts/pacman-key.sh.in
>> index e5b6021..d2389b0 100644
>> --- a/scripts/pacman-key.sh.in
>> +++ b/scripts/pacman-key.sh.in
>> @@ -301,7 +301,6 @@ populate_keyring() {
>> if (( ${#trusted_ids[@]} > 0 )); then
>> msg "$(gettext "Locally signing trusted keys in keyring...")"
>> for key_id in "${!trusted_ids[@]}"; do
>> - msg2 "$(gettext "Locally signing key %s...")" "${key_id}"
>> lsign_keys "${key_id}"
>> done
>
> I'd suggest to replace the entire for loop with this then:
>
> lsign_keys "${!trusted_ids[@]}"
>

Amended on my working branch.

Allan


All times are GMT. The time now is 09:42 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.