FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.

» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > ArchLinux > ArchLinux Pacman Development

LinkBack Thread Tools
Old 03-09-2012, 06:59 AM
Allan McRae
Default fix some safety issues in makepkg

With the upcoming makepkg-lobotomy (removing the error trap apart from
in the actual packaging steps), we need to add some more error checking
and be as safe as possible when potentially dealing with strange variable

Some of these are a bit unnecessary (e.g. using printf to output
variables that almost certainly cannot start with a "-n"), but there is
no harm in applying them globally.

Allan McRae (6):
makepkg: the rhs in string comparisons should be quoted
makepkg: use printf rather than echo to output variable
makepkg: prevent issues with files starting with a hyphen
makepkg: abort when failing to create BUILDDIR
makepkg: quote removed filename as it can have spaces
makepkg: safely change directories

scripts/makepkg.sh.in | 147 ++++++++++++++++++++++++++-----------------------
1 file changed, 79 insertions(+), 68 deletions(-)


Thread Tools

All times are GMT. The time now is 06:46 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org