FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > ArchLinux > ArchLinux Pacman Development

 
 
LinkBack Thread Tools
 
Old 04-02-2008, 05:49 PM
Nagy Gabor
 
Default No error in makepkg when removing deps fails

>
> From 9beeed7c54d94a95c9e0bccb863e9b09ea18bd4f Mon Sep 17 00:00:00 2001
> From: Allan McRae <mcrae_allan@hotmail.com>
> Date: Thu, 3 Apr 2008 01:07:25 +1000
> Subject: [PATCH] No error in makepkg when removing deps fails
>
> Catches error from when pacman is unable to remove dependencies after
> successfully building package and prints warning. Fixes FS#10039.
>
> Signed-off-by: Allan McRae <mcrae_allan@hotmail.com>
> ---
> scripts/makepkg.sh.in | 11 +++++++++--
> 1 files changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in
> index 1eb3d3a..395d525 100644
> --- a/scripts/makepkg.sh.in
> +++ b/scripts/makepkg.sh.in
> @@ -447,10 +447,17 @@ remove_deps() {
> done
>
> msg "Removing installed dependencies..."
> + local ret=0
> if [ "$ASROOT" = "0" ]; then
> - sudo pacman $PACMAN_OPTS -Rns $deplist
> + sudo pacman $PACMAN_OPTS -Rns $deplist || ret=$?
> else
> - pacman $PACMAN_OPTS -Rns $deplist
> + pacman $PACMAN_OPTS -Rns $deplist || ret=$?
> + fi
> +
> + # Fixes FS#10039 - exit cleanly as package has built successfully
> + if [ $ret -ne 0 ]; then
> + warning "$(gettext "Failed to remove installed dependencies.")"
> + return 0
> fi
> }
>
> --
> 1.5.4.5
>

Well, imho this whole method is ugly. We should somehow collect the installed
packages, because '-R provision' doesn't work. And trying to install
dependencies with stripped pkgver, I don't know... [Not talking about the rare
case of unwanted orphan removal by remove_deps]

Bye


----------------------------------------------------
SZTE Egyetemi Könyvtár - http://www.bibl.u-szeged.hu
This mail sent through IMP: http://horde.org/imp/


_______________________________________________
pacman-dev mailing list
pacman-dev@archlinux.org
http://archlinux.org/mailman/listinfo/pacman-dev
 

Thread Tools




All times are GMT. The time now is 05:36 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright ©2007 - 2008, www.linux-archive.org