FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > ArchLinux > ArchLinux Pacman Development

 
 
LinkBack Thread Tools
 
Old 08-09-2011, 10:56 AM
Sebastien Luttringer
 
Default Clean is done everytime it's asked for

Before this, cleaning is done when script exit with a value != 0.
If a build fail, directory remain unclean. The purpose of cleaning should
not be changed if build fail.

Signed-off-by: Sebastien Luttringer <seblu@seblu.net>
---
scripts/makepkg.sh.in | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in
index fa12702..05880b7 100644
--- a/scripts/makepkg.sh.in
+++ b/scripts/makepkg.sh.in
@@ -134,10 +134,10 @@ clean_up() {
return
fi

- if (( ! EXIT_CODE && CLEANUP )); then
+ if (( CLEANUP )); then
local pkg file

- # If it's a clean exit and -c/--clean has been passed...
+ # Cleaning if -c/--clean has been passed...
msg "$(gettext "Cleaning up...")"
rm -rf "$pkgdir" "$srcdir"
if [[ -n $pkgbase ]]; then
--
Sebastien "Seblu" Luttringer
 
Old 08-12-2011, 04:58 PM
Dave Reisner
 
Default Clean is done everytime it's asked for

On Tue, Aug 09, 2011 at 12:56:41PM +0200, Sebastien Luttringer wrote:
> Before this, cleaning is done when script exit with a value != 0.
> If a build fail, directory remain unclean. The purpose of cleaning should
> not be changed if build fail.

I think this is intended behavior. One might want to investigate _why_ a
build failed by looking in the $srcdir.

dave

> Signed-off-by: Sebastien Luttringer <seblu@seblu.net>
> ---
> scripts/makepkg.sh.in | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in
> index fa12702..05880b7 100644
> --- a/scripts/makepkg.sh.in
> +++ b/scripts/makepkg.sh.in
> @@ -134,10 +134,10 @@ clean_up() {
> return
> fi
>
> - if (( ! EXIT_CODE && CLEANUP )); then
> + if (( CLEANUP )); then
> local pkg file
>
> - # If it's a clean exit and -c/--clean has been passed...
> + # Cleaning if -c/--clean has been passed...
> msg "$(gettext "Cleaning up...")"
> rm -rf "$pkgdir" "$srcdir"
> if [[ -n $pkgbase ]]; then
> --
> Sebastien "Seblu" Luttringer
>
>
 
Old 08-12-2011, 04:59 PM
Lukas Fleischer
 
Default Clean is done everytime it's asked for

On Tue, Aug 09, 2011 at 12:56:41PM +0200, Sebastien Luttringer wrote:
> Before this, cleaning is done when script exit with a value != 0.
> If a build fail, directory remain unclean. The purpose of cleaning should
> not be changed if build fail.
>
> Signed-off-by: Sebastien Luttringer <seblu@seblu.net>
> ---
> scripts/makepkg.sh.in | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>

-1. The purpose of this is to be able to analyze the build directory in
case of a build failure which makes it easier to spot and backtrack any
errors.

> diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in
> index fa12702..05880b7 100644
> --- a/scripts/makepkg.sh.in
> +++ b/scripts/makepkg.sh.in
> @@ -134,10 +134,10 @@ clean_up() {
> return
> fi
>
> - if (( ! EXIT_CODE && CLEANUP )); then
> + if (( CLEANUP )); then
> local pkg file
>
> - # If it's a clean exit and -c/--clean has been passed...
> + # Cleaning if -c/--clean has been passed...
> msg "$(gettext "Cleaning up...")"
> rm -rf "$pkgdir" "$srcdir"
> if [[ -n $pkgbase ]]; then
> --
> Sebastien "Seblu" Luttringer
 

Thread Tools




All times are GMT. The time now is 09:50 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org