FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.

» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > ArchLinux > ArchLinux Pacman Development

LinkBack Thread Tools
Old 07-16-2011, 02:15 PM
Allan McRae
Default makepkg: fix issue with filenames with spaces break and noextract

Specifying a filename with spaces in a PKGBUILDs noextract array fails
due to a lack of quoting.

Fixes FS#25100.

Reported-by: Thomas Weißschuh <<thomas_weissschuh@lavabit.com>
Signed-off-by: Allan McRae <allan@archlinux.org>

Can probably go on maint in case we ever make another release from there.

scripts/makepkg.sh.in | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in
index 16c4400..74dfa43 100644
--- a/scripts/makepkg.sh.in
+++ b/scripts/makepkg.sh.in
@@ -758,7 +758,7 @@ extract_sources() {
local netfile
for netfile in "${source[@]}"; do
local file=$(get_filename "$netfile")
- if in_array "$file" ${noextract[@]}; then
+ if in_array "$file" "${noextract[@]}"; then
#skip source files in the noextract=() array
# these are marked explicitly to NOT be extracted

Thread Tools

All times are GMT. The time now is 09:19 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright ©2007 - 2008, www.linux-archive.org