Instead of using || echo, which IMO is a silly hack, the only proper
way to check the
exit status of a command substitution is:

if ! var=$(command); then
* commands
fi

This patch changes that in makepkg, and gets rid of a pre-optimization
that served
no purpose in in_array().

Thanks.

On Thu, Jul 7, 2011 at 9:13 PM, DJ Mills <danielmills1@gmail.com> wrote:
> Instead of using || echo, which IMO is a silly hack, the only proper
> way to check the
> exit status of a command substitution is:
>
> if ! var=$(command); then
> * commands
> fi

Why isn't this in the commit message?

Please read HACKING
(http://www.archlinux.org/pacman/submitting-patches.html), send
patches inline, and include a signoff. Thanks!


> This patch changes that in makepkg, and gets rid of a pre-optimization
> that served
> no purpose in in_array().
>
> Thanks.
>
>
>
>