FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > ArchLinux > ArchLinux Pacman Development

 
 
LinkBack Thread Tools
 
Old 07-08-2011, 02:13 AM
DJ Mills
 
Default Fwd: PATCH: fixed set -e hack in makepkg

Instead of using || echo, which IMO is a silly hack, the only proper
way to check the
exit status of a command substitution is:

if ! var=$(command); then
* commands
fi

This patch changes that in makepkg, and gets rid of a pre-optimization
that served
no purpose in in_array().

Thanks.
 
Old 07-08-2011, 02:47 AM
Dan McGee
 
Default Fwd: PATCH: fixed set -e hack in makepkg

On Thu, Jul 7, 2011 at 9:13 PM, DJ Mills <danielmills1@gmail.com> wrote:
> Instead of using || echo, which IMO is a silly hack, the only proper
> way to check the
> exit status of a command substitution is:
>
> if ! var=$(command); then
> * commands
> fi

Why isn't this in the commit message?

Please read HACKING
(http://www.archlinux.org/pacman/submitting-patches.html), send
patches inline, and include a signoff. Thanks!


> This patch changes that in makepkg, and gets rid of a pre-optimization
> that served
> no purpose in in_array().
>
> Thanks.
>
>
>
>
 

Thread Tools




All times are GMT. The time now is 09:39 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org