FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > ArchLinux > ArchLinux Pacman Development

 
 
LinkBack Thread Tools
 
Old 07-05-2011, 11:51 AM
Allan McRae
 
Default parse_options: add missing newlines

Signed-off-by: Allan McRae <allan@archlinux.org>
---
scripts/library/parse_options.sh | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/library/parse_options.sh b/scripts/library/parse_options.sh
index 5ced260..9622230 100644
--- a/scripts/library/parse_options.sh
+++ b/scripts/library/parse_options.sh
@@ -25,7 +25,7 @@ parse_options() {
shift
printf " '%s'" "$1"
else
- printf "@SCRIPTNAME@: $(gettext "option %s requires an argument")" "'$1'" >&2
+ printf "@SCRIPTNAME@: $(gettext "option %s requires an argument
")" "'$1'" >&2
ret=1
fi
fi
@@ -50,7 +50,7 @@ parse_options() {
shift
printf " '%s'" "${1}"
else
- printf "@SCRIPTNAME@: $(gettext "option %s requires an argument")" "'-${1:i:1}'" >&2
+ printf "@SCRIPTNAME@: $(gettext "option %s requires an argument
")" "'-${1:i:1}'" >&2
ret=1
fi
fi
--
1.7.6
 
Old 07-05-2011, 01:37 PM
Dan McGee
 
Default parse_options: add missing newlines

On Tue, Jul 5, 2011 at 6:51 AM, Allan McRae <allan@archlinux.org> wrote:
> Signed-off-by: Allan McRae <allan@archlinux.org>

I'll signoff, with a catch- looks like this file never got added to
the relevant POTFILES.in so these strings will be lost if the
translations are updated.

> ---
> *scripts/library/parse_options.sh | * *4 ++--
> *1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/library/parse_options.sh b/scripts/library/parse_options.sh
> index 5ced260..9622230 100644
> --- a/scripts/library/parse_options.sh
> +++ b/scripts/library/parse_options.sh
> @@ -25,7 +25,7 @@ parse_options() {
> * * * * * * * * * * * * * * * * * * * * * * * * * * * *shift
> * * * * * * * * * * * * * * * * * * * * * * * * * * * *printf " '%s'" "$1"
> * * * * * * * * * * * * * * * * * * * * * * * *else
> - * * * * * * * * * * * * * * * * * * * * * * * * * * * printf "@SCRIPTNAME@: $(gettext "option %s requires an argument")" "'$1'" >&2
> + * * * * * * * * * * * * * * * * * * * * * * * * * * * printf "@SCRIPTNAME@: $(gettext "option %s requires an argument
")" "'$1'" >&2
> * * * * * * * * * * * * * * * * * * * * * * * * * * * *ret=1
> * * * * * * * * * * * * * * * * * * * * * * * *fi
> * * * * * * * * * * * * * * * * * * * *fi
> @@ -50,7 +50,7 @@ parse_options() {
> * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *shift
> * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *printf " '%s'" "${1}"
> * * * * * * * * * * * * * * * * * * * * * * * * * * * *else
> - * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * printf "@SCRIPTNAME@: $(gettext "option %s requires an argument")" "'-${1:i:1}'" >&2
> + * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * printf "@SCRIPTNAME@: $(gettext "option %s requires an argument
")" "'-${1:i:1}'" >&2
> * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *ret=1
> * * * * * * * * * * * * * * * * * * * * * * * * * * * *fi
> * * * * * * * * * * * * * * * * * * * * * * * *fi
> --
> 1.7.6
>
>
>
 
Old 07-05-2011, 01:51 PM
Allan McRae
 
Default parse_options: add missing newlines

On 05/07/11 23:37, Dan McGee wrote:

On Tue, Jul 5, 2011 at 6:51 AM, Allan McRae<allan@archlinux.org> wrote:

Signed-off-by: Allan McRae<allan@archlinux.org>


I'll signoff, with a catch- looks like this file never got added to
the relevant POTFILES.in so these strings will be lost if the
translations are updated.



Stuck a patch adding this file and the output_format.sh one to the
relevant POTFILES.in. Is that all that needs done there?


Allan
 
Old 07-05-2011, 01:55 PM
Dan McGee
 
Default parse_options: add missing newlines

On Tue, Jul 5, 2011 at 8:51 AM, Allan McRae <allan@archlinux.org> wrote:
> On 05/07/11 23:37, Dan McGee wrote:
>>
>> On Tue, Jul 5, 2011 at 6:51 AM, Allan McRae<allan@archlinux.org> *wrote:
>>>
>>> Signed-off-by: Allan McRae<allan@archlinux.org>
>>
>> I'll signoff, with a catch- looks like this file never got added to
>> the relevant POTFILES.in so these strings will be lost if the
>> translations are updated.
>>
>
> Stuck a patch adding this file and the output_format.sh one to the relevant
> POTFILES.in. *Is that all that needs done there?

Yeah that should be it. Easiest way to check things out is
$ make -C scripts/po pacman-scripts.pot-update

And look at the resulting translation catalog.

-Dan
 

Thread Tools




All times are GMT. The time now is 05:03 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org