FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > ArchLinux > ArchLinux Pacman Development

 
 
LinkBack Thread Tools
 
Old 06-30-2011, 04:34 AM
Dave Reisner
 
Default lib/alpm: unlock the handle before freeing it

This avoids, probably among other things, leaving the lock file in place
after a SIGINT interrupts a sync DB update.

Fixes regression introduced in 4f8ae2b.

Signed-off-by: Dave Reisner <dreisner@archlinux.org>
---
Dan this seems to work (surviving a variety of -Sy and -Syu <pkg> testcases)
and pactest doesn't complain, but you know this portion of the code way
better than I do. Does this seem sane?

lib/libalpm/alpm.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/lib/libalpm/alpm.c b/lib/libalpm/alpm.c
index b0bbbe8..d35512b 100644
--- a/lib/libalpm/alpm.c
+++ b/lib/libalpm/alpm.c
@@ -117,6 +117,7 @@ int SYMEXPORT alpm_release(pmhandle_t *myhandle)
ret = -1;
}

+ _alpm_handle_unlock(myhandle);
_alpm_handle_free(myhandle);

#ifdef HAVE_LIBCURL
--
1.7.6
 

Thread Tools




All times are GMT. The time now is 01:00 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org