FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > ArchLinux > ArchLinux Pacman Development

 
 
LinkBack Thread Tools
 
Old 06-23-2011, 04:48 AM
Eric Bélanger
 
Default makepkg: Added checks in check_software for distcc, ccache, strip and gzip

On Thu, Jun 23, 2011 at 12:02 AM, Eric Bélanger <snowmaniscool@gmail.com> wrote:
> Signed-off-by: Eric Bélanger <snowmaniscool@gmail.com>
> ---
>
> I thought about adding checks for the PKGEXT and SRCEXT compression utilities but I'm not sure as it might be overkill. *Anyway, they could always be added later on in another patch. BTW, I didn't test this patch as it seemed quite straightforward.
>

I forgot to mention it but this patch changes a bit how makepkg use
distcc and ccache. Currently, if the distcc or ccache options are
used and they are not installed, makepkg simply doesn't enable the
support and build the package like normal. However, with this patch,
makepkg will aborts. To keep current behavoir, the error message for
distcc and ccache will need to be replaced by a warning message.
 
Old 06-24-2011, 02:10 AM
Dan McGee
 
Default makepkg: Added checks in check_software for distcc, ccache, strip and gzip

On Wed, Jun 22, 2011 at 11:48 PM, Eric Bélanger <snowmaniscool@gmail.com> wrote:
> On Thu, Jun 23, 2011 at 12:02 AM, Eric Bélanger <snowmaniscool@gmail.com> wrote:
>> Signed-off-by: Eric Bélanger <snowmaniscool@gmail.com>
>> ---
>>
>> I thought about adding checks for the PKGEXT and SRCEXT compression utilities but I'm not sure as it might be overkill. *Anyway, they could always be added later on in another patch. BTW, I didn't test this patch as it seemed quite straightforward.
>>
>
> I forgot to mention it but this patch changes a bit how makepkg use
> distcc and ccache. *Currently, if the distcc or ccache options are
> used and they are not installed, makepkg simply doesn't enable the
> support and build the package like normal. However, with this patch,
> makepkg will aborts. To keep current behavoir, the error message for
> distcc and ccache will need to be replaced by a warning message.

This seems fine to me. Allan, thoughts? The only other thing I could
think of doing is fail if set in BUILDENV and not available, but don't
fail if specified in PKGBUILD options.

-Dan
 

Thread Tools




All times are GMT. The time now is 05:20 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright ©2007 - 2008, www.linux-archive.org