FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.

» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > ArchLinux > ArchLinux Pacman Development

LinkBack Thread Tools
Old 06-07-2011, 11:38 PM
Allan McRae
Default Require handle for alpm_find_grp_pkgs()

On 08/06/11 08:29, Dan McGee wrote:

On Tue, Jun 7, 2011 at 5:19 PM, Rémy Oudompheng
<remyoudompheng@gmail.com> wrote:

On 2011/6/7 Dan McGee<dan@archlinux.org> wrote:

-alpm_list_t SYMEXPORT *alpm_find_grp_pkgs(alpm_list_t *dbs,
+alpm_list_t SYMEXPORT *alpm_find_grp_pkgs(pmhandle_t *handle, alpm_list_t *dbs,
const char *name)
alpm_list_t *i, *j, *pkgs = NULL, *ignorelist = NULL;

I don't see where the handle is needed in this function.

It's needed in the subsequent patches that move pm_errno to the
handle; I tried anything to make that one smaller and this was one bit
that could be split out. Barely worth it, I know, but trying every
little bit...

It that for subsequent patches in this patchset or future patches? At
the end of the current patchset, I find these two functions that do not
use the handle argument:

diff --git a/lib/libalpm/package.c b/lib/libalpm/package.c
index 7071e89..ceae3f8 100644
--- a/lib/libalpm/package.c
+++ b/lib/libalpm/package.c
@@ -538,7 +538,7 @@ pmpkg_t *_alpm_pkg_find(alpm_list_t *haystack, const
char *n

* @return 1 if the package should be ignored, 0 otherwise
-int _alpm_pkg_should_ignore(pmhandle_t *handle, pmpkg_t *pkg)
+int _alpm_pkg_should_ignore(pmhandle_t UNUSED *handle, pmpkg_t *pkg)
alpm_list_t *groups = NULL;

diff --git a/lib/libalpm/sync.c b/lib/libalpm/sync.c
index 81d4de2..2652424 100644
--- a/lib/libalpm/sync.c
+++ b/lib/libalpm/sync.c
@@ -213,7 +213,7 @@ int SYMEXPORT alpm_sync_sysupgrade(pmhandle_t
*handle, int e

* @param name the name of the group
* @return the list of pmpkg_t * (caller is responsible for

-alpm_list_t SYMEXPORT *alpm_find_grp_pkgs(pmhandle_t *handle,
alpm_list_t *dbs,
+alpm_list_t SYMEXPORT *alpm_find_grp_pkgs(pmhandle_t UNUSED *handle,

Thread Tools

All times are GMT. The time now is 08:04 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright ©2007 - 2008, www.linux-archive.org