FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > ArchLinux > ArchLinux Pacman Development

 
 
LinkBack Thread Tools
 
Old 06-07-2011, 03:48 PM
Dan McGee
 
Default Remove incorrect output when downloading only

On Mon, Jun 6, 2011 at 11:36 AM, Nagy Gabor <ngaba@bibl.u-szeged.hu> wrote:
>> Patch looks fine to me but some minor comments :
>>
>> 1) just a matter of taste, I would reduce the number of levels with
>> if (prompt && download)
>> * install = 1
>> else if prompt
>> * ...
>> else
>> * ...
>>
>> 2) can we have downloadonly and prompt=0 ? do we want to print the warning
>> in
>> that case ?
>>
>> 3) that patch highlights that these 2 blocks are completely *identical and
>> could
>> maybe be factored like that :
>> if (install_ignorepkg(pkg))
>> *install = 1
>> else
>> *ignored = 1
>> *continue
>
> 4) Would not be better to leave the "install = 1" decision to the
> front-end's callback function? I am not sure everyone wants that default
> here.

I think I agree with Nagy here, or at least something doesn't feel
quite right with the second part of this as much as the first part.
For now I'll apply the first hunk to maint, and we'll get the second
part sorted out soon enough.

-Dan
 

Thread Tools




All times are GMT. The time now is 09:03 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org