Linux Archive

Linux Archive (http://www.linux-archive.org/)
-   ArchLinux Pacman Development (http://www.linux-archive.org/archlinux-pacman-development/)
-   -   Remove dead stores reported by clang-analyzer (http://www.linux-archive.org/archlinux-pacman-development/509191-remove-dead-stores-reported-clang-analyzer.html)

Xavier Chantry 04-03-2011 07:35 AM

Remove dead stores reported by clang-analyzer
 
On Sun, Apr 3, 2011 at 8:14 AM, Sebastian Nowicki <sebnow@gmail.com> wrote:
> Signed-off-by: Sebastian Nowicki <sebnow@gmail.com>
> ---
> *lib/libalpm/be_local.c | * *2 +-
> *lib/libalpm/pkghash.c *| * *3 +--
> *2 files changed, 2 insertions(+), 3 deletions(-)
>

I didn't send these yesterday to the ML as they looked trivial enough,
but maybe I should have.
http://code.toofishes.net/cgit/xavier/pacman.git/log/?h=working

Sebastian Nowicki 04-03-2011 08:15 AM

Remove dead stores reported by clang-analyzer
 
On Sun, Apr 3, 2011 at 3:35 PM, Xavier Chantry <chantry.xavier@gmail.com>wrote:

> On Sun, Apr 3, 2011 at 8:14 AM, Sebastian Nowicki <sebnow@gmail.com>
> wrote:
> > Signed-off-by: Sebastian Nowicki <sebnow@gmail.com>
> > ---
> > lib/libalpm/be_local.c | 2 +-
> > lib/libalpm/pkghash.c | 3 +--
> > 2 files changed, 2 insertions(+), 3 deletions(-)
> >
>
> I didn't send these yesterday to the ML as they looked trivial enough,
> but maybe I should have.
> http://code.toofishes.net/cgit/xavier/pacman.git/log/?h=working
>
>
I thought you might have already done this when you found the open_mode bug
from clang-analyzer :).

Allan McRae 04-05-2011 02:07 AM

Remove dead stores reported by clang-analyzer
 
On 04/04/11 18:58, Xavier wrote:

Allan McRae wrote:


Please send patches to the list so that we can complain about issues like:

aba191d5 (Xavier Chantry 2011-04-03 10:28:09 +0200 276)
printf("%lc", *p);

util.c: In function ‘indentprint’:
util.c:276:3: error: format ‘%lc’ expects argument of type ‘wint_t’,
but argument 2 has type ‘wchar_t’ [-Werror=format]
cc1: all warnings being treated as errors




This one was not supposed to be committed, I know Dan would have rejected it
anyway.
I was just pissed off by this dumb issue, and I did not manage to make gcc
break. Is that with gcc 4.6 (I was on 4.5) ?



OK.

That was with a gcc-4.7 snapshot (which is still quite close to what
gcc-4.6 is).


Allan


All times are GMT. The time now is 06:11 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.