FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > ArchLinux > ArchLinux Pacman Development

 
 
LinkBack Thread Tools
 
Old 07-21-2008, 12:03 PM
Nagy Gabor
 
Default Re-enable --debug with -Sw and -Sp

>From c533684914d28407a0a7399e3026c747987d5de3 Mon Sep 17 00:00:00 2001
From: Nagy Gabor <ngaba@bibl.u-szeged.hu>
Date: Mon, 21 Jul 2008 13:57:02 +0200
Subject: [PATCH] Re-enable --debug with -Sw and -Sp

Commit 874190827676e3a974e8c5fef6c51b9e9d6b60fa disabled --debug in these
cases. We just clear PM_LOG_WARNING flag now.

Signed-off-by: Nagy Gabor <ngaba@bibl.u-szeged.hu>
---
src/pacman/sync.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/pacman/sync.c b/src/pacman/sync.c
index b154b91..20daada 100644
--- a/src/pacman/sync.c
+++ b/src/pacman/sync.c
@@ -740,7 +740,7 @@ int pacman_sync(alpm_list_t *targets)

/* Display only errors with -Sp and -Sw operations */
if(config->flags & (PM_TRANS_FLAG_DOWNLOADONLY | PM_TRANS_FLAG_PRINTURIS)) {
- config->logmask = PM_LOG_ERROR;
+ config->logmask = config->logmask & ~PM_LOG_WARNING;
}

/* clean the cache */
--
1.5.6.3


_______________________________________________
pacman-dev mailing list
pacman-dev@archlinux.org
http://archlinux.org/mailman/listinfo/pacman-dev
 
Old 07-21-2008, 12:23 PM
Xavier
 
Default Re-enable --debug with -Sw and -Sp

On Mon, Jul 21, 2008 at 2:03 PM, Nagy Gabor <ngaba@bibl.u-szeged.hu> wrote:
> >From c533684914d28407a0a7399e3026c747987d5de3 Mon Sep 17 00:00:00 2001
> From: Nagy Gabor <ngaba@bibl.u-szeged.hu>
> Date: Mon, 21 Jul 2008 13:57:02 +0200
> Subject: [PATCH] Re-enable --debug with -Sw and -Sp
>
> Commit 874190827676e3a974e8c5fef6c51b9e9d6b60fa disabled --debug in these
> cases. We just clear PM_LOG_WARNING flag now.
>
> Signed-off-by: Nagy Gabor <ngaba@bibl.u-szeged.hu>
> ---
> src/pacman/sync.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/src/pacman/sync.c b/src/pacman/sync.c
> index b154b91..20daada 100644
> --- a/src/pacman/sync.c
> +++ b/src/pacman/sync.c
> @@ -740,7 +740,7 @@ int pacman_sync(alpm_list_t *targets)
>
> /* Display only errors with -Sp and -Sw operations */
> if(config->flags & (PM_TRANS_FLAG_DOWNLOADONLY | PM_TRANS_FLAG_PRINTURIS)) {
> - config->logmask = PM_LOG_ERROR;
> + config->logmask = config->logmask & ~PM_LOG_WARNING;
> }
>
> /* clean the cache */
> --
> 1.5.6.3
>
>

Ooops, debug levels are applied before that code indeed, good catch.

_______________________________________________
pacman-dev mailing list
pacman-dev@archlinux.org
http://archlinux.org/mailman/listinfo/pacman-dev
 
Old 07-21-2008, 02:58 PM
Miklos Vajna
 
Default Re-enable --debug with -Sw and -Sp

On Mon, Jul 21, 2008 at 02:03:57PM +0200, Nagy Gabor <ngaba@bibl.u-szeged.hu> wrote:
> @@ -740,7 +740,7 @@ int pacman_sync(alpm_list_t *targets)
>
> /* Display only errors with -Sp and -Sw operations */
> if(config->flags & (PM_TRANS_FLAG_DOWNLOADONLY | PM_TRANS_FLAG_PRINTURIS)) {
> - config->logmask = PM_LOG_ERROR;
> + config->logmask = config->logmask & ~PM_LOG_WARNING;
> }
>
> /* clean the cache */

Minor nit: why not using &=?
_______________________________________________
pacman-dev mailing list
pacman-dev@archlinux.org
http://archlinux.org/mailman/listinfo/pacman-dev
 

Thread Tools




All times are GMT. The time now is 06:21 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org