FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > ArchLinux > ArchLinux Pacman Development

 
 
LinkBack Thread Tools
 
Old 07-01-2008, 05:47 PM
Thomas Bchler
 
Default Add rundepends keyword to makepkg

When a package A requires a package B at runtime, but B is not
needed for building A or B cannot be installed while A is being
built, rundepends=('B') can be used to add B to A's dependencies,
omitting the dependency check at built time.
---
scripts/makepkg.sh.in | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in
index c45d7e8..c809498 100644
--- a/scripts/makepkg.sh.in
+++ b/scripts/makepkg.sh.in
@@ -809,7 +809,7 @@ create_package() {
for it in "${groups[@]}"; do
echo "group = $it" >>.PKGINFO
done
- for it in "${depends[@]}"; do
+ for it in "${depends[@]} ${rundepends[@]}"; do
echo "depend = $it" >>.PKGINFO
done
for it in "${optdepends[@]}"; do
@@ -1287,7 +1287,7 @@ fi

unset pkgname pkgver pkgrel pkgdesc url license groups provides md5sums
unset replaces depends conflicts backup source install build makedepends
-unset optdepends options noextract
+unset optdepends options noextract rundepends

if [ ! -f "$BUILDSCRIPT" ]; then
error "$(gettext "%s does not exist.")" "$BUILDSCRIPT"
--
1.5.6


_______________________________________________
pacman-dev mailing list
pacman-dev@archlinux.org
http://archlinux.org/mailman/listinfo/pacman-dev
 
Old 07-01-2008, 06:11 PM
"Dan McGee"
 
Default Add rundepends keyword to makepkg

On Tue, Jul 1, 2008 at 12:47 PM, Thomas Bchler <thomas@archlinux.org> wrote:
> When a package A requires a package B at runtime, but B is not
> needed for building A or B cannot be installed while A is being
> built, rundepends=('B') can be used to add B to A's dependencies,
> omitting the dependency check at built time.
> ---
> scripts/makepkg.sh.in | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in
> index c45d7e8..c809498 100644
> --- a/scripts/makepkg.sh.in
> +++ b/scripts/makepkg.sh.in
> @@ -809,7 +809,7 @@ create_package() {
> for it in "${groups[@]}"; do
> echo "group = $it" >>.PKGINFO
> done
> - for it in "${depends[@]}"; do
> + for it in "${depends[@]} ${rundepends[@]}"; do
> echo "depend = $it" >>.PKGINFO
> done
> for it in "${optdepends[@]}"; do
> @@ -1287,7 +1287,7 @@ fi
>
> unset pkgname pkgver pkgrel pkgdesc url license groups provides md5sums
> unset replaces depends conflicts backup source install build makedepends
> -unset optdepends options noextract
> +unset optdepends options noextract rundepends
>
> if [ ! -f "$BUILDSCRIPT" ]; then
> error "$(gettext "%s does not exist.")" "$BUILDSCRIPT"
> --

I've been contemplating something like this for a while as well. What
do others on the list think, is this getting to be too much, or does
this make sense? I think I would be fine with it. We will need
documentation (namely PKGBUILD.5.txt) to be patched as well in the
final patch.

-Dan
_______________________________________________
pacman-dev mailing list
pacman-dev@archlinux.org
http://archlinux.org/mailman/listinfo/pacman-dev
 
Old 07-01-2008, 07:22 PM
Miklos Vajna
 
Default Add rundepends keyword to makepkg

On Tue, Jul 01, 2008 at 01:11:11PM -0500, Dan McGee <dpmcgee@gmail.com> wrote:
> I've been contemplating something like this for a while as well. What
> do others on the list think, is this getting to be too much, or does
> this make sense? I think I would be fine with it. We will need
> documentation (namely PKGBUILD.5.txt) to be patched as well in the
> final patch.

http://bugs.archlinux.org/task/2891

Aaron closed this as "Wont't implement" two years ago.
_______________________________________________
pacman-dev mailing list
pacman-dev@archlinux.org
http://archlinux.org/mailman/listinfo/pacman-dev
 
Old 07-01-2008, 07:32 PM
Thomas Bchler
 
Default Add rundepends keyword to makepkg

Miklos Vajna schrieb:

I've been contemplating something like this for a while as well. What
do others on the list think, is this getting to be too much, or does
this make sense? I think I would be fine with it. We will need
documentation (namely PKGBUILD.5.txt) to be patched as well in the
final patch.


Didn't think of that.


http://bugs.archlinux.org/task/2891

Aaron closed this as "Wont't implement" two years ago.


It is a good feature for a packager. I am doing some packages where I
always have to build with -d, as some of the dependencies are never
present at build time. However, I still want makepkg to check whether
all other dependencies are there.


_______________________________________________
pacman-dev mailing list
pacman-dev@archlinux.org
http://archlinux.org/mailman/listinfo/pacman-dev
 
Old 07-01-2008, 07:42 PM
"Dan McGee"
 
Default Add rundepends keyword to makepkg

On Tue, Jul 1, 2008 at 2:32 PM, Thomas Bchler <thomas@archlinux.org> wrote:
> Miklos Vajna schrieb:
>>>
>>> I've been contemplating something like this for a while as well. What
>>> do others on the list think, is this getting to be too much, or does
>>> this make sense? I think I would be fine with it. We will need
>>> documentation (namely PKGBUILD.5.txt) to be patched as well in the
>>> final patch.
>
> Didn't think of that.
>
>> http://bugs.archlinux.org/task/2891
>>
>> Aaron closed this as "Wont't implement" two years ago.

My name isn't Aaron, now is it?

> It is a good feature for a packager. I am doing some packages where I always
> have to build with -d, as some of the dependencies are never present at
> build time. However, I still want makepkg to check whether all other
> dependencies are there.

I do see the use in this because I build regularly where I need to
use the -d option, which unfortunately prevents a single dependency
from being checked. Two years is a long time, so there has been plenty
of time to reconsider, and I find the reasons in the bug report just
as valid as they were two years ago.

-Dan
_______________________________________________
pacman-dev mailing list
pacman-dev@archlinux.org
http://archlinux.org/mailman/listinfo/pacman-dev
 
Old 07-01-2008, 11:35 PM
Miklos Vajna
 
Default Add rundepends keyword to makepkg

On Tue, Jul 01, 2008 at 02:42:15PM -0500, Dan McGee <dpmcgee@gmail.com> wrote:
> >> http://bugs.archlinux.org/task/2891
> >>
> >> Aaron closed this as "Wont't implement" two years ago.
>
> My name isn't Aaron, now is it?

OK, it was just a FYI. :-)
_______________________________________________
pacman-dev mailing list
pacman-dev@archlinux.org
http://archlinux.org/mailman/listinfo/pacman-dev
 
Old 07-02-2008, 01:41 AM
Allan McRae
 
Default Add rundepends keyword to makepkg

Dan McGee wrote:
>
> I do see the use in this because I build regularly where I need to
> use the -d option, which unfortunately prevents a single dependency
> from being checked. Two years is a long time, so there has been plenty
> of time to reconsider, and I find the reasons in the bug report just
> as valid as they were two years ago.
>

I like the idea as I frequently use -d for x86_64 rebuilds and this
would make it easier to build in a clean chroot.

Allan



_______________________________________________
pacman-dev mailing list
pacman-dev@archlinux.org
http://archlinux.org/mailman/listinfo/pacman-dev
 
Old 07-02-2008, 07:12 AM
"Roman Kyrylych"
 
Default Add rundepends keyword to makepkg

2008/7/1 Dan McGee <dpmcgee@gmail.com>:
> On Tue, Jul 1, 2008 at 12:47 PM, Thomas Bächler <thomas@archlinux.org> wrote:
>> When a package A requires a package B at runtime, but B is not
>> needed for building A or B cannot be installed while A is being
>> built, rundepends=('B') can be used to add B to A's dependencies,
>> omitting the dependency check at built time.
>> ---
>> scripts/makepkg.sh.in | 4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in
>> index c45d7e8..c809498 100644
>> --- a/scripts/makepkg.sh.in
>> +++ b/scripts/makepkg.sh.in
>> @@ -809,7 +809,7 @@ create_package() {
>> for it in "${groups[@]}"; do
>> echo "group = $it" >>.PKGINFO
>> done
>> - for it in "${depends[@]}"; do
>> + for it in "${depends[@]} ${rundepends[@]}"; do
>> echo "depend = $it" >>.PKGINFO
>> done
>> for it in "${optdepends[@]}"; do
>> @@ -1287,7 +1287,7 @@ fi
>>
>> unset pkgname pkgver pkgrel pkgdesc url license groups provides md5sums
>> unset replaces depends conflicts backup source install build makedepends
>> -unset optdepends options noextract
>> +unset optdepends options noextract rundepends
>>
>> if [ ! -f "$BUILDSCRIPT" ]; then
>> error "$(gettext "%s does not exist.")" "$BUILDSCRIPT"
>> --
>
> I've been contemplating something like this for a while as well. What
> do others on the list think, is this getting to be too much, or does
> this make sense? I think I would be fine with it. We will need
> documentation (namely PKGBUILD.5.txt) to be patched as well in the
> final patch.

The proposed functionality is useful (I've encountered situation
described by Thomas),
but IMO this will add some confusion.
Most people would just use depends even for run-time-only depends
(when they're not cirlular, of course),
so rundepends would be used only to workaround those circular builddepends.

What I did to workaround the situation described by Thomas:
* build A without depends=(B)
* add depends=(B) and repackage with makepkg -R

--
Roman Kyrylych (*оман Кирилич)
_______________________________________________
pacman-dev mailing list
pacman-dev@archlinux.org
http://archlinux.org/mailman/listinfo/pacman-dev
 
Old 07-15-2008, 06:27 AM
Allan McRae
 
Default Add rundepends keyword to makepkg

Thomas Bchler wrote:
> When a package A requires a package B at runtime, but B is not
> needed for building A or B cannot be installed while A is being
> built, rundepends=('B') can be used to add B to A's dependencies,
> omitting the dependency check at built time.
>
>

Any chance of resubmitting this with the required documentation added
(PKGBUILD.5.txt and addition to PKGBUILD.proto)? I think that this
patch can be included once that is done.

Allan



_______________________________________________
pacman-dev mailing list
pacman-dev@archlinux.org
http://archlinux.org/mailman/listinfo/pacman-dev
 

Thread Tools




All times are GMT. The time now is 06:34 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org