On Tue, Aug 14, 2012 at 10:10:51AM +0200, Vratislav Podzimek wrote:
> On Mon, 2012-08-13 at 09:36 -0700, Brian C. Lane wrote:
> > I like tests to be in their own directory tree. They make the core
> > source directories harder to read when you add _test.py to every file
> > that's already in there and I think it also helps keep some separation
> > between tests and the code.
> > I think the most useful thing we can do (other than better upkeep of the
> > tests) is integration of the test run into the build process, during
> > make release and rpm's %check section.
> That would definitely force us to update tests along with the patches.
> But it will also cause many build fails and I am afraid we cannot afford
> such problems in these days.
You wouldn't need to fail a build. Just run them and get used to seeing
> For me, the idea of having _test.py file next to the source file looks
> good. I think it brings more advantages than disadvantages (there seems
> to be only one).
> And couldn't git help us with the "mess in files problem"? I was
> thinking about separate *-tests branches for the tests, that would
> contain also the _test.py files. But it would likely be hard to merge
> e.g. master changes to master-tests. Any other ideas?
A separate branch would never stay in sync. We have a hard enough time
with the tests/ directory on-branch as it is
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
Anaconda-devel-list mailing list