FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > ArchLinux > ArchLinux General Discussion

 
 
LinkBack Thread Tools
 
Old 06-01-2012, 08:56 AM
Martin Gracik
 
Default Network spoke: fix endless loop in refresh_ui (bad merge of patches)

ack to both

----- Original Message -----
> The removed block is a leftover of a (bad) approach to config
> refresh.
>
> ---
> pyanaconda/ui/gui/spokes/network.py | 14 +-------------
> 1 files changed, 1 insertions(+), 13 deletions(-)
>
> diff --git a/pyanaconda/ui/gui/spokes/network.py
> b/pyanaconda/ui/gui/spokes/network.py
> index 0fe4295..c959eeb 100644
> --- a/pyanaconda/ui/gui/spokes/network.py
> +++ b/pyanaconda/ui/gui/spokes/network.py
> @@ -611,6 +611,7 @@ class NetworkControlBox():
> ipv4cfg = None
> ipv6cfg = None
>
> + # We might need to wait for config objects to become
> available
> if num_of_tries > 0:
> ipv4cfg = device.get_ip4_config()
> ipv6cfg = device.get_ip6_config()
> @@ -619,19 +620,6 @@ class NetworkControlBox():
> num_of_tries-1))
> return False
>
> - # We might need to wait for config objects to become
> available
> - if device.get_state() ==
> NetworkManager.DeviceState.ACTIVATED:
> - # Activating device with neither ipv4 nor ipv6
> configured shouldn't
> - # loop endlessly so set timeout
> - timeout = 1
> - while timeout > 0 and not ipv4cfg and not ipv6cfg:
> - while GLib.main_context_default().iteration(False):
> - pass
> - ipv4cfg = device.get_ip4_config()
> - ipv6cfg = device.get_ip6_config()
> - time.sleep(0.3)
> - timeout = timeout - 0.3
> -
> dev_type = device.get_device_type()
> if dev_type == NetworkManager.DeviceType.ETHERNET:
> dt = "wired"
> --
> 1.7.4
>
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list@redhat.com
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list
>

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 

Thread Tools




All times are GMT. The time now is 01:05 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org