Linux Archive

Linux Archive (http://www.linux-archive.org/)
-   ArchLinux General Discussion (http://www.linux-archive.org/archlinux-general-discussion/)
-   -   Rewrite /etc/crypttab processing. (http://www.linux-archive.org/archlinux-general-discussion/393368-rewrite-etc-crypttab-processing.html)

Thomas Bächler 06-30-2010 10:16 PM

Rewrite /etc/crypttab processing.
 
Am 30.06.2010 23:47, schrieb Victor Lowther:
> Split out reading /etc/crypttab and procssing the individual lines into
> their own helper functions, and bashify the resulting shorter code.
>
> Processing this file is still ugly, though. :(

I wanted to factor this out and deprecate crypttab for a long time. This
is a good first step.

However, there are still things in this commit that do not belong there,
again. While your work here is appreciated, and I am looking forward to
applying most (all?) of it, you will probably have to re-do many of the
commit due to these errors.

I'll stop reviewing now and continue with 33-48 tomorrow.

Victor Lowther 06-30-2010 10:29 PM

Rewrite /etc/crypttab processing.
 
On Thu, 2010-07-01 at 00:16 +0200, Thomas Bächler wrote:
> Am 30.06.2010 23:47, schrieb Victor Lowther:
> > Split out reading /etc/crypttab and procssing the individual lines into
> > their own helper functions, and bashify the resulting shorter code.
> >
> > Processing this file is still ugly, though. :(
>
> I wanted to factor this out and deprecate crypttab for a long time. This
> is a good first step.

Danke.

> However, there are still things in this commit that do not belong there,
> again. While your work here is appreciated, and I am looking forward to
> applying most (all?) of it, you will probably have to re-do many of the
> commit due to these errors.

No problem, I got a little crazier with the ol' git rebase than I should
have.

> I'll stop reviewing now and continue with 33-48 tomorrow.

I look forward to it.

--
Victor Lowther
LPIC2 UCP RHCE


All times are GMT. The time now is 04:29 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.